Repository navigation
Fix the crash of the file system properties dialog box, and lengthen the encryption option box on the creation interface. - #231
Merged
Conversation
…the encryption option box on the creation interface.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The supplied changes are narrow, correct the formatting arguments, and have no identified blocking issues.
No open issues 🎉
What changed in this PR
Fixes string formatting in the filesystem properties dialog to prevent crashes, and updates release metadata and Chinese documentation.
Changes:
- Passes wide-character string pointers to the dialog’s buffer-size and cache-duration formatting calls.
- Documents XChaCha20-Poly1305 encryption and its command-line option in the Chinese README.
- Bumps the version to
1.4.5.1.
| File | Description |
|---|---|
version.txt |
Updates the version to 1.4.5.1. |
README_zh-CN.md |
Adds XChaCha20-Poly1305 and --chacha documentation. |
cppcryptfs/ui/FsInfoDialog.cpp |
Corrects string arguments in two formatting calls. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.