Repository navigation
feat: add no comment flow - #951
Merged
Merged
Conversation
- Convert use-controllable to TypeScript with proper generics (was a plain .js file, causing type-check errors across 5 consumers) - Add type argument to useControllable calls in dialog/drawer - Fix prettier formatting in rules.test.mjs - Freeze pre-existing comment-discipline debt into authoring-baseline.json
guilherme-santana-azion
approved these changes
Sep 1, 2026
robson-junior-azion
approved these changes
Sep 2, 2026
Merged
gabriel-lisboa-azion
added a commit
that referenced
this pull request
Sep 21, 2026
demo/vue-sample had drifted 540 ahead / 31 behind main while most of its webkit work was reviewed and landed upstream (#941 command-menu, #942 GlobalHeader placements, #943 NavigationMenu, #952 Menu, #960 sidebar collapse, #973 floating-panel placement, #975 paginator, #977 templates exports, #921 amount ladder), after which main swept comments (#951) and reworked the CLI onto a derived bundle (#968/#970). Main is the source for everything the two share. Of the 28 conflicted source files, 17 differed from main only in comments — their code was byte-identical — and 6 more were genuinely newer on main, so all 23 take main verbatim, including the use-placement TypeScript rewrite that replaces the old index.js. Three carve-outs keep demo work main does not have yet: - sidebar: main's CSS-driven collapse is the base; the `side` axis is re-applied on top of it as data-[side=end] variants rather than the JS edge map it used to be, and the drag sign moves into the rail composable. The one test that asserted the removed inline transform now asserts the panel's published edge, since the direction is CSS the unstyled test env cannot see. - theme: texts.data.js keeps demo's 13 extra text-wrap and 10 extra tracking declarations (PR #982, in flight). Both sides carry the same 34 entries, so an entry count would not have caught the loss. - doc-prose keeps its chrome-padding fix (PR #981, in flight). catalog.json, authoring-baseline.json, the theme dist and the lockfile are regenerated rather than hand-resolved; the 13 conflicted visual baselines take main's and are regenerated from CI next. Verified: every file main touched is byte-identical to main except the 22 accounted for above; 2364 browser tests, 179 toolkit tests, lint, vue-tsc, 99.98% type coverage, both ratchets, the Storybook build and the webkit-sample build all pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verbose-comment-block(blocks comment blocks longer than 5 lines) andcomment-heavy-file(blocks files that are ≥20% prose comments) — enforcingcomments.md: comments should be rare and objective, not narration.authoring-baseline.jsonso the ratchet lands without forcing a full-repo rewrite in this PR; new code is held to the rule immediately.use-controllablewas a plain.jsfile with no generics, which madevue-tscreject everyuseControllable<T>(...)call site (accordion, dropdown, dialog, drawer, popover, tooltip). Converted it to typed TypeScript (use-controllable.ts+index.ts) and added the missing type argument indialog.vue/drawer.vue.How to test
pnpm --filter @aziontech/webkit run authoring— construction-standard ratchet passes with0 newviolations.pnpm --filter @aziontech/webkit run type-check—vue-tsc --noEmitpasses (previously failed with 10 errors across accordion/dropdown/dialog/drawer/popover/tooltip).pnpm --filter @aziontech/webkit run test:toolkit— the newcomment-heavy-file/verbose-comment-blockchecks are covered.pnpm run governance— full local gate (lint, stylelint, format, type-check, type-coverage, audit) is green.Notes
None — no breaking change, no new dependency.
authoring-baseline.jsonrecords pre-existing debt only; it does not grandfather anything introduced by this PR.