Repository navigation
feat(webkit): [ENG-47357] add footer composition component - #877
Merged
Merged
Conversation
- token the social-bar border-top width (--border-width-default) instead of the implicit 1px - add active and visited states to Footer.Link per the Design task's state scope - add a size-limit budget for footer-root - cover both single-slot branches of the social bar's conditional render
- add the column divider borders and fix the social-bar border token (--border-default, not --border-muted), per node 5467:1642 - remove the outer columns padding/gap in favor of per-column padding, matching Figma's flex-1 + 0 column-gap layout - fix the social-bar right-cluster gap (status <-> language) to --spacing-lg, and lock the bar to h-14 at md+ - enrich the story: all 7 social icons, the language Select (with an explicit aria-label so the combobox has an accessible name distinct from its displayed value), matching the frame's anatomy
border-(length:--border-width-default) sets width on ALL FOUR sides, not just the paired border-r/border-t. Combined with border-r/border-t, every column and the social bar picked up unwanted left/top/bottom borders too — visible as a doubled line at each column seam and an inconsistent right edge. Switched to the per-side border-r-(length:...) / border-t-(length:...) form already used in panel-header.vue / table-row.vue, with border-0 to zero every side first.
isaque-bock-azion
marked this pull request as draft
August 12, 2026 18:21
# Conflicts: # packages/webkit/catalog.json # packages/webkit/package.json
The suite loads no theme CSS and runs no Tailwind (src/test/setup.ts), so axe here checks semantics only. The comment claimed a styled tree, which reads as though contrast were covered; contrast lives in Storybook + visual regression.
isaque-bock-azion
marked this pull request as ready for review
August 14, 2026 20:38
# Conflicts: # packages/webkit/.size-limit.json
…pe scale The footer baselines were generated before #876 lightened the heading and body weights (400 → 300) and tightened the body leading, so every one of the six footer modes drifted ~1% against them. Regenerated on linux via the Storybook Regenerate Baseline workflow; the full matrix reports these six files as the only ones that moved.
The Figma set (5467:1638) moved the brand out of the social bar into its own framed signature band beside a tagline, and wrapped the footer in page material: two hatched gutters flanking the measure and a hatched band closing it below. The four bands are cells of ONE grid, so each stays a single element in a single place in the DOM while their order changes — `order-*` when stacked, explicit row/column placement from `md` — instead of a desktop-only wrapper row that would duplicate the consumer's slot content. Three breakpoints, each for its own reason: the column grid folds below `md`; the bands recombine at `md`, which the social row now fits because the brand left it; the gutters wait for `xl`, the first breakpoint past the 1192px measure, since earlier they resolve to zero width and still paint their corner marks on the measure's own edges. The slot set is reshaped with it: `social-start` / `social-end` become `social`, `status`, `language`, `brand` and `tagline`. `language` and `status` are separate slots because they swap order between the two Figma variants, and every name is now a single word, so the spec's Slots table carries all of them instead of needing a prose note for the hyphenated keys. This is not a breaking change — the footer landed on this branch and has never been released, so the slots it is replacing have no consumer. The bundle budget for `footer-root` goes 1.1 KB -> 4 KB: the footer now composes `FrameBox` (1.93 KB on its own), which is the design's own frame rather than growth to trim away.
The gutters draw only the rule they share with the measure (`left` / `right`), the signature keeps just its `top`, and the closing band carries `all` four — so every rule in the footer is drawn once, by the box that owns it, instead of neighbours meeting on the same line.
isaque-bock-azion
force-pushed
the
feat/ENG-47357-footer
branch
from
August 17, 2026 17:42
cf614bb to
0655abe
Compare
All six modes moved: the brand left the social bar for its own signature band, the bands recombine at md, and the gutters and closing band are new. Only components-layout-footer--default-footer changed — 6 files, no additions or deletions — which is the whole scope of the redesign.
The story used r/azion; the community is r/aziontech. The href feeds both the canvas and the "Show code" snippet from the same const, so the copy a consumer pastes is corrected with it.
guilherme-santana-azion
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
layout/footercomposition component (Footer+Footer.Column+Footer.Link) — the page-footer counterpart toGlobalHeader, ported from the site's footer and rewritten on semantic tokens (--bg-canvas,--border-muted,--text-muted/--text-default,--spacing-*,.text-label-sm), per epic ENG-47354.mdbreakpoint: 4-column grid folds to the 2×2 mobile grid, and the social bar stacks with the status/language cluster above the brand/social cluster (FigmaType=Default/Type=Mobile)..specs/footer.md), flat exports (./footer,./footer-root,./footer-column,./footer-link), theComponents/Layout/Footerstory, and a co-located browser-mode test suite (20 tests incl. axe).How to test
pnpm storybook:dev→ openComponents/Layout/Footer→ Default: four link columns over the social bar; resize below 768px and confirm the 2×2 grid and the stacked bar (status above brand).pnpm --filter webkit exec vitest run src/components/layout/footer/footer.test.ts→ 20 tests pass (compound API, provide/inject testids, conditional social bar, nav landmarks, attr fallthrough, axe).pnpm webkit:lint && pnpm webkit:type-check && pnpm webkit:type-coverage && pnpm storybook:build→ all green.Notes
Brand,IconButton,StatusIndicator,Select) and renders only when a social slot is provided.max-w-(--container-5xl)(1192px) until tokenized.Storybook Regenerate Baselineworkflow run on this branch (macOS renders don't match the linux snapshots).