feat(theme): add a text-heading-3xl rung above the heading ladder - #1045
Open
gabriel-lisboa-azion wants to merge 2 commits into
Open
gabriel-lisboa-azion wants to merge 2 commits into
gabriel-lisboa-azion wants to merge 2 commits into
Conversation
The display size that text-heading-2xl carried moves up to a new text-heading-3xl, and text-heading-2xl becomes a step smaller (3xl / 4xl / 5xl). tracking.tighter tightens to -0.16rem and is kept for those two display rungs; the rest of the heading ladder sets tracking.normal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
text-heading-3xl, which takes over the display sizetext-heading-2xlhad (3xl / 5xl / 6xl, tight leading), for the one headline a page opens on.text-heading-2xlbecomes a step smaller (3xl / 4xl / 5xl, no leading), andtracking.tightertightens from −0.05rem to −0.16rem for these two display rungs;xland below now settracking.normal.How to test
pnpm --filter @aziontech/theme build:tokens→dist/v4/globals.cssgains thetext-heading-3xlutility;node --test "test/**/*.test.mjs"in packages/theme → 17 pass.Heading 3xlaboveHeading 2xl, each with its new size and tracking.text-heading-2xl).Notes
text-heading-2xlconsumer (hero-title, doc-page-header, doc-prose's h1): they render a step smaller. Move a headline totext-heading-3xlto keep the old size. Expect the visual job to need a baseline regen for those stories.packages/webkit/catalog.jsonis regenerated for the new token, so the squash also touches webkit.