fix(webkit): render field-textarea's helper text through HelperText - #1043
Open
gabriel-lisboa-azion wants to merge 1 commit into
Open
gabriel-lisboa-azion wants to merge 1 commit into
gabriel-lisboa-azion wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FieldTextarearenders its helper throughHelperTextinstead of a hand-rolled<small>, the same contractFieldTextalready uses: the field resolves only the helper'skind(disabled→invalid→required→helper), andHelperTextowns the type, colour and lock glyph.HelperTextowns them.How to test
npx vitest run src/components/inputs/field-textareafrom packages/webkit → all pass, including the newhelper kindcases.FieldText's in each state.Notes
FieldText's:…__helperstays, and…__helper-text/…__helper-iconbecome…__helper__text/…__helper__icon. Consumer tests that target the old ids need the new ones.