Repository navigation
fix(webkit): STO-16 link field-multi-select option labels to their checkbox input - #1041
Merged
robson-junior-azion merged 1 commit intoSep 30, 2026
Merged
Conversation
…input Pass inputId instead of id to the PrimeVue Checkbox so the option label's for attribute targets the input rather than the root div. Clicking the option text now toggles the checkbox and the checkbox gets an accessible name.
robson-junior-azion
deleted the
fix/webkit-field-multi-select-label-input-id
branch
September 30, 2026 19:29
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 30, 2026
## [3.9.4](https://github.com/aziontech/webkit/compare/@aziontech/webkit@3.9.3...@aziontech/webkit@3.9.4) (2026-09-30) ### Bug Fixes * **theme:** restore theme to @aziontech/theme@2.6.0 ([#1022](#1022)) ([3882556](3882556)) * **webkit:** link field-multi-select option labels to their checkbox input ([#1041](#1041)) ([194bf55](194bf55))
Contributor
|
🎉 This PR is included in version 3.9.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context - STO-16
QA report item STO-16 (Console 2.8.4): in Create Credential (
/credentials/object-storageand the bucket's Credentials tab), clicking a capability's name or description, such as "Read Files", does nothing. Only the checkbox square responds. The checkboxes also have no accessible name.Root cause
field-multi-selectpassed:idto the PrimeVue 3.35Checkbox. Thatidlands on the rootdiv.p-checkbox, not on the hidden<input>, so<label for="capabilities_readFiles">pointed to adiv.document.getElementById('capabilities_readFiles').tagNamereturnedDIV.Fix
Pass
inputIdinstead ofid. The input now carries the id, so the label is associated with it.The toggle still happens only once: the label click turns into a click on the input, which bubbles to the Checkbox root, where PrimeVue's single
onClickhandler computes the new value frommodelValue.Impact
FormFieldsCredential.vuein the console (Credentials and the bucket's Credentials tab).option.labelandoption.description, no slot), so there are no links or buttons inside it that a larger click target could interfere with.src/testsselects the checkbox by that id. The e2e helpertests/support/ui/storage.jsuses focus + Space, which still works. It can now usegetByRole('checkbox', { name }).Validation
Playwright in Chromium against the
Core/Form/FieldMultiSelectstories:getElementByIdreturnsINPUT✅With the change reverted, the same script fails (no checkbox with an accessible name).
eslinton the changed file ✅pnpm webkit:build:dtsandpnpm storybook:buildnot run