feat(webkit): add the band-stack marketing component - #1036
Open
gabriel-lisboa-azion wants to merge 2 commits into
Open
gabriel-lisboa-azion wants to merge 2 commits into
gabriel-lisboa-azion wants to merge 2 commits into
Conversation
Each band keeps its top and bottom rules but no marks of its own. The stack provides a context (band-stack/injection-key.ts) that tells a media-split band to frame its copy and media cells as two frame-boxes, left and right, each with its four registration marks, so both sides of every seam are ticked.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BandStack(@aziontech/webkit/band-stack): a run of framed bands that share one hairline between neighbours; each direct child of the default slot is one band.stickypins each band under the site header fromlgup, a step lower than the one before, so the run piles up as you scroll;flushdrops the first band's top rule.Components/Marketing/BandStackstory, browser test, export and a size row (2.22 KB of 2.5 KB).How to test
pnpm --filter @aziontech/webkit exec vitest run src/components/marketing/band-stack→ 9 tests pass.sticky, scroll → each band pins a step below the previous one; earlier bands stay visible as ledges.flush→ the first band's top rule disappears; neighbours never draw a double rule.Notes
media-split(feat(webkit): add the media-split marketing component #1008), which renders once that PR is infeature/marketing-components.