Repository navigation
feat(webkit): frame the site footer's column and close it on a full-bleed rule - #1029
Merged
Merged
Conversation
# Conflicts: # apps/storybook/.storybook/test-visual/__image_snapshots__/linux/components-layout-footer--site-placement--dark-mobile.png # apps/storybook/.storybook/test-visual/__image_snapshots__/linux/components-layout-footer--site-placement--dark-tablet.png # apps/storybook/.storybook/test-visual/__image_snapshots__/linux/components-layout-footer--site-placement--light-desktop.png # apps/storybook/.storybook/test-visual/__image_snapshots__/linux/components-layout-footer--site-placement--light-mobile.png # apps/storybook/.storybook/test-visual/__image_snapshots__/linux/components-layout-footer--site-placement--light-tablet.png
guilherme-santana-azion
approved these changes
Oct 6, 2026
isaque-bock-azion
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Footer's main column is aFrameBox(data-testid="layout-footer__frame"): inkind="site"it draws the side rules and all four corner marks; incontentit draws none.kind="site"drops the hatched closing band and closes on a full-bleed bottom rule.footer-rootsize budget (4 → 3.5 KB, measured 3.15 KB) updated.How to test
cd packages/webkit && npx vitest run src/components/layout/footer/footer.test.ts→ all pass.content) → no side rules, marks or bottom rule; visually unchanged.Notes
data-testid="layout-footer__closing"no longer exists; tests that query it will fail. Newlayout-footer__frameon the column wrapper.kind="site"is visually different: the closing band (64px, 192px frommd) is gone, four corner marks appear, the bottom edge is one full-bleed rule.kind="content"only gains the wrapper element.