fix(webkit): animate code-block line entrance on the translate property - #1027
Open
gabriel-lisboa-azion wants to merge 1 commit into
Open
gabriel-lisboa-azion wants to merge 1 commit into
gabriel-lisboa-azion wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
animateLines) and tab-swap line motion transitiontranslateinstead oftransform: under Tailwind v4-translate-x-2/translate-x-0set the standalonetranslateproperty, so the slide never interpolated and lines only faded.animateLinesstagger drops from 300ms to 40ms per line.How to test
cd packages/webkit && npx vitest run src/components/data/code-block/code-block.test.ts→ 39 tests pass, including "line entrance".<CodeBlock :animate-lines="true">with a multi-line snippet and reload → each line slides in from the left while fading, 40ms after the previous one.Notes
animateLinesblocks enter 7.5× faster. No API change..specs/code-block.md; whichever merges second rebases and recomputes the spec checksum.