Skip to content

refactor(page-content): use the theme's layout-boundary-inline for the prose column #2380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isaque-bock-azion merged 1 commit into from
Sep 21, 2026
Merged

refactor(page-content): use the theme's layout-boundary-inline for the prose column #2380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions src/components/PageContent/PageContent.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,6 @@ const headerLabels = {
} -->
<article class="pt-(--spacing-md) pb-12">
{
/*
* THE MASTHEAD IS A BANNER, THE PROSE IS A COLUMN. The header is NOT in
* `px-container` — it spans the content column edge to edge, so the rule it
* closes on reads as the page's own horizon instead of a line under the
* title. Its words still land on the container's measure, because
* `doc-page-banner` pads it by exactly what `px-container` would have
* (see the style below), so nothing has to fight the component's own border.
*/
content.page_header !== false && (
<DocPageHeader
class="doc-page-banner mb-8"
Expand All @@ -87,7 +79,7 @@ const headerLabels = {
/>
)
}
<section class="px-container">
<section class="layout-boundary-inline">
<ReadableContent client:load>
{
isFallback && (
Expand All @@ -102,13 +94,6 @@ const headerLabels = {
</section>

{
/*
* The pair carries its own column and its own close: `px-container` is the
* measure the prose above it takes, and `pt-12` is the 48 that closes a
* section in the prose contract. It used to sit in an `aside` — a second
* landmark around a `nav` that already has one — under an `hr` that spent
* another 48 saying the same thing.
*/
(previous || next) && (
<DocPagination
previous={previous && { title: previous.text, href: previous.link }}
Expand Down
Loading