Skip to content

docs(masters): confirm edit-page region widget renders for LAUNCHED campaigns (#776) - #789

Merged
axisrow merged 1 commit into
mainfrom
feat/776-launched-region-verify
Aug 6, 2026
Merged

docs(masters): confirm edit-page region widget renders for LAUNCHED campaigns (#776)#789
axisrow merged 1 commit into
mainfrom
feat/776-launched-region-verify

Conversation

@axisrow

@axisrow axisrow commented Aug 6, 2026

Copy link
Copy Markdown
Owner

Summary

Settles issue #776's unproven assumption: does WIZARD_EDIT_URL render the "Регион показов" widget (RegionsTreeTagGroup.tags-wrapper) for a genuinely LAUNCHED (non-DRAFT) Мастер кампаний campaign, not just on the create page?

Verification (live, read-only, no --launch)

Once goal support unblocked masters add (#777/#779), the obvious next step looked like creating a fresh test campaign with --launch — but that publishes real live ads with real budget spend and no rollback. Instead: the rendering fact in question doesn't depend on how a campaign became ACTIVE, so it was checked against an existing production campaign already running before this issue:

$ masters get 713234191 --format json
{
  "CampaignId": 713234191,
  "Status": "ACTIVE",
  "LandingUrl": "https://lp.ksamata.ru/detox_ya",
  "Stats": {"impressions": "11 271", "clicks": "388", "cost": "457,22 ₽"}
}

Confirmed non-DRAFT with real impressions/clicks/spend. Reloading its WIZARD_EDIT_URL and inspecting the DOM:

document.querySelector('[data-testid="RegionsTreeTagGroup.tags-wrapper"]')
// found, offsetParent !== null (visible), 36 region tags rendered

Result: the edit page does render the region widget for a genuinely launched campaign. _verify_created's existing reload-and-reread approach (direct_cli/browser/masters.py) was already correct — no code change to the verification logic itself.

Changes

Only _verify_created's docstring: replaced the "not field-proven" / risk-flagged wording with the confirmed live-verification note (campaign ID, method, result), per the issue's own resolution steps (#2: "capture ... replace the softened docstring wording with a real live-verification note").

No new fixture was captured — the check used the DOM directly (data-testid presence + visibility + tag count) rather than a saved HTML snapshot, since the goal was answering a yes/no rendering question, not adding new fixture-based test coverage.

Tests

  • pytest -k masters — 678 passed, 9 subtests passed (offline, unaffected by this docs-only change)
  • black --check / flake8 clean

Closes #776

🤖 Generated with Claude Code

…ampaigns (#776)

Live read-only verification against existing production campaign
713234191 (masters get -> Status=ACTIVE, real impressions/clicks/cost)
confirms WIZARD_EDIT_URL renders RegionsTreeTagGroup.tags-wrapper
(visible, 36 region tags) for a genuinely non-DRAFT campaign — no new
--launch needed, since the rendering fact does not depend on how the
campaign reached ACTIVE.

_verify_created's reload-and-reread approach was already correct; only
the docstring's softened/unverified wording is replaced with the
confirmed live-verification note.

Closes #776

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L4kfKGyGa5bSWSTRDfpGgx
@axisrow
axisrow merged commit 4f870e9 into main Aug 6, 2026
6 checks passed
@axisrow

axisrow commented Aug 6, 2026

Copy link
Copy Markdown
Owner Author

📋 Review summary — all cycles

Reviewed locally (/code-review ×4 + Codex companion ×3, no bots pinged). Both reviewers were unanimous.

Cycle Reviewer Finding Verdict Resolution
1 codex Docstring-only change; live-verification claim internally consistent with unchanged code below it SKIP No action needed — approve, no critical issues
1 claude (/code-review) Docstring-only change; live-verification claim internally consistent with unchanged code below it SKIP No action needed — 0 findings across 4 independent runs

Totals: 0 FIX, 0 SKIP-actionable, 0 UNVERIFIED. PR is a pure docstring change confirming issue #776's design item; no executable code modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

masters add: confirm the edit page renders the region widget for a LAUNCHED campaign

1 participant