refactor(commands): hoist set-bids boilerplate into make_set_bids_command - #746
Merged
Conversation
…mand (#589 C12) dynamicads, audiencetargets, smartadtargets and dynamicfeedadtargets each duplicated the same set-bids command body (selector/bid field collection, selector+bid validation, setBids payload assembly). Extract the shared factory into commands/_set_bids.py, matching the make_lifecycle_command/ make_get_command pattern already used for lifecycle and get commands. CLI surface, option order, error text, and --dry-run payloads are byte-identical, including smartadtargets' distinct "no selector required" validation and the untyped --priority truthy check preserved via BidField.truthy.
Owner
Author
📋 Review summary — all cyclesLocal review (
Totals: 0 FIX, 0 SKIP, 0 UNVERIFIED. Both configured reviewers returned a clean verdict on round 1 (head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #589 (C12).
Investigation of issue #589's three items found #11 (
_*_lifecycle()→register_lifecycle_commands) and #13 (execute_add/execute_requesttail) already implemented and adopted across the codebase in earlier commits — the only remaining gap was C12:set-bidsboilerplate duplicated acrossdynamicads,audiencetargets,smartadtargets,dynamicfeedadtargets.direct_cli/commands/_set_bids.py::make_set_bids_command, modeled on the existing_lifecycle.py/_get.pyfactory pattern.set-bidswith one call, passing its resource-specific bid fields asBidFieldtuples.--priorityuses a truthy check (if value:), notis not None, matching all 4 originals.smartadtargets set-bidsnever actually required a target selector (checkedif not bid_datainstead of the selector group) — kept viarequire_selector=False.Test plan
pytest— full offline suite: 3123 passed, 23 skipped (no changes)black/flake8on touched files — clean--helpdiff for all 4set-bidscommands — option order/text unchanged🤖 Generated with Claude Code
https://claude.ai/code/session_01Rkv1ZdgUPefeXM5q3eepTe