test(integration): record real bids cassettes for TestWriteBidsRead - #193
Merged
Conversation
The original cassettes only captured the sandbox_keyword fixture setup (campaigns/adgroups/keywords) because the Yandex sandbox rejects keywords.add with code 8800. As a result, both bids tests skipped in replay-mode and provided no actual /v5/bids coverage. Workaround: - Recorded against the live API (sandbox-bypass via temporary patch to conftest._invoke), then rewrote request hosts in the cassettes from api.direct.yandex.ru to api-sandbox.direct.yandex.ru so they replay under the default --sandbox test setup. - test_bids_set_auto needed --position PREMIUMBLOCK alongside --scope SEARCH (live API error 9600: 'You need to enter Position to update the bid for search'). Added the flag. Result: both tests now PASS in replay-mode and exercise real /v5/bids interactions. Dropped the @pytest.mark.sandbox_limitation marker on the class since the limitation is now resolved. Token, login and identifying personal data scrubbed by the existing VCR hooks in conftest.py; verified manually post-recording.
There was a problem hiding this comment.
Pull request overview
Improves integration write test coverage for the v5 bids service by updating the TestWriteBidsRead VCR cassettes so replay-mode exercises real /json/v5/bids interactions (instead of skipping after fixture setup failures).
Changes:
- Updated
TestWriteBidsReaddocumentation and removed the@pytest.mark.sandbox_limitationmarker so the tests run in replay-mode. - Fixed
test_bids_set_autoto include--position PREMIUMBLOCKalongside--scope SEARCHto satisfy the live API contract. - Re-recorded/updated VCR cassettes to include successful
bids.getandbids.setAutointeractions, with URIs rewritten to the sandbox host for replay.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_integration_write.py | Un-skips bids read/auto tests and updates the set-auto invocation to include --position. |
| tests/cassettes/test_integration_write/TestWriteBidsRead.test_bids_get.yaml | Cassette now contains a real /json/v5/bids get interaction (plus setup/teardown). |
| tests/cassettes/test_integration_write/TestWriteBidsRead.test_bids_set_auto.yaml | Cassette now contains a real /json/v5/bids setAuto interaction (plus setup/teardown). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously the
TestWriteBidsReadcassettes only capturedsandbox_keywordfixture setup (campaigns/adgroups/keywords) because Yandex sandbox rejectskeywords.addwith code 8800. Both bids tests were skipping in replay-mode, providing no actual/v5/bidsendpoint coverage (flagged in PR #189 second-pass Opus review).Approach
conftest._invoke, immediately reverted).api.direct.yandex.ru→api-sandbox.direct.yandex.ruin the YAMLs so replay works under the default--sandboxtest setup.test_bids_set_autoto pass--position PREMIUMBLOCKalongside--scope SEARCH(live API error 9600 otherwise).@pytest.mark.sandbox_limitationmarker.Verification
pytest -q -m integration_write tests/test_integration_write.py::TestWriteBidsRead→ 2 passed (was 2 skipped).integration_writesuite: 12 passed, 11 skipped (was 10 passed, 13 skipped — net +2)./json/v5/bidsinteractions.Refs: closes the residual finding from PR #189 second-pass Opus review (TestWriteBidsRead coverage gap).