-
Notifications
You must be signed in to change notification settings - Fork 1
feat(ads get): add --text-ad-fields for type-specific field retrieval #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -89,7 +89,7 @@ def parse_date(date_str: str) -> str: | |||||
| "ClientInfo", | ||||||
| ], | ||||||
| "adgroups": ["Id", "Name", "CampaignId", "Status", "Type", "RegionIds"], | ||||||
| "ads": ["Id", "CampaignId", "AdGroupId", "Status", "State", "Type"], | ||||||
| "ads": ["Id", "CampaignId", "AdGroupId", "Status", "State", "Type", "TextAd"], | ||||||
|
||||||
| "ads": ["Id", "CampaignId", "AdGroupId", "Status", "State", "Type", "TextAd"], | |
| "ads": ["Id", "CampaignId", "AdGroupId", "Status", "State", "Type"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--dry-runis checked aftercreate_client(...). If the user runsdirect ads get --dry-runwithoutYANDEX_DIRECT_TOKEN,create_client()will raise (token required) and the dry-run path won't work. Move client creation (and any token resolution) to after thedry_runearly-return so dry-run can run without credentials, consistent withads add/update.