Skip to content

revert: remove CUSTOM strategy and semanticOverride support - #713

Merged
aidandaly24 merged 3 commits into
mainfrom
revert/custom-and-semantic-override
Mar 27, 2026
Merged

revert: remove CUSTOM strategy and semanticOverride support#713
aidandaly24 merged 3 commits into
mainfrom
revert/custom-and-semantic-override

Conversation

@aidandaly24

@aidandaly24 aidandaly24 commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Description

Reverts two features that were prematurely merged:

  1. CUSTOM memory strategy (beac707 / feat(memory): add CUSTOM strategy type to agentcore-cli (#677) #694) — removes the CUSTOM strategy type from the schema, CLI wizards, templates, docs, and validation
  2. Semantic override (5e0f584 / feat: add semanticOverride support for SEMANTIC memory strategies #696) — removes semanticOverride field from MemoryStrategy, including schemas, types, exports, and cross-field validation

EPISODIC strategy support is intentionally preserved throughout.

What changed

  • MemoryStrategyTypeSchema enum: 5 → 4 values (removed CUSTOM)
  • Removed SemanticOverrideSchema, SemanticExtractionOverrideSchema, SemanticConsolidationOverrideSchema and all exports
  • Removed semanticOverride field from MemoryStrategySchema and .superRefine() cross-field validation
  • Removed custom option from create/add-agent wizards and CLI flags
  • Removed CUSTOM Handlebars blocks from Python session templates
  • Removed mapExistingMemoriesToProviders and memory deduplication logic
  • Updated docs (commands.md, configuration.md, memory.md)
  • Restored EPISODIC row in configuration.md (inadvertently removed by the CUSTOM revert)

Related Issue

Reverts #694, #696

Type of Change

  • Other (please describe): Revert of prematurely merged features

Testing

How have you tested the change?

  • I ran npm run test:unit and npm run test:integ
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@aidandaly24
aidandaly24 requested a review from a team March 27, 2026 21:58
@github-actions github-actions Bot added the size/l PR size: L label Mar 27, 2026
@github-actions

github-actions Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.3.0-preview.9.0.tgz

How to install

npm install https://github.com/aws/agentcore-cli/releases/download/pr-713-tarball/aws-agentcore-0.3.0-preview.9.0.tgz

@aidandaly24
aidandaly24 force-pushed the revert/custom-and-semantic-override branch from 8327ac7 to 013467b Compare March 27, 2026 22:06
@github-actions github-actions Bot added size/l PR size: L and removed size/l PR size: L labels Mar 27, 2026
jesseturner21
jesseturner21 previously approved these changes Mar 27, 2026
View reviewed changes
@aidandaly24
fix: restore EPISODIC strategy to configuration.md
ae62347 
The revert of the CUSTOM strategy commit inadvertently removed the
EPISODIC row from the Memory Strategies table in configuration.md.
@github-actions

github-actions Bot commented Mar 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 46% 6552 / 14242
🔵 Statements 45.57% 6962 / 15276
🔵 Functions 44.71% 1176 / 2630
🔵 Branches 46.09% 4331 / 9395
Generated in workflow #1479 for commit ae62347 by the Vitest Coverage Report Action

@aidandaly24
aidandaly24 force-pushed the revert/custom-and-semantic-override branch from 013467b to ae62347 Compare March 27, 2026 22:13
@github-actions github-actions Bot added size/l PR size: L and removed size/l PR size: L labels Mar 27, 2026
@aidandaly24
aidandaly24 merged commit 6ff721e into main Mar 27, 2026
19 checks passed
@aidandaly24
aidandaly24 deleted the revert/custom-and-semantic-override branch March 27, 2026 22:19
@aidandaly24 aidandaly24 mentioned this pull request Mar 28, 2026
Merged
15 tasks
notgitika added a commit to notgitika/agentcore-cli that referenced this pull request Aug 18, 2026
@notgitika
revert: drop CUSTOM memory strategy from "project add memory"
f9d76d0 
Reverts 87be86e. I added CUSTOM because the CDK schema already had it in
MemoryStrategyTypeSchema, which turns out to be the argument PR aws#694 made --
and aws#713 reverted a day later.

The CLI has removed CUSTOM twice on purpose. Offering the type without
somewhere to put its extraction configuration is aws#241 ("select custom memory
strategy, note there is no option to add prompts"); aws#266 removed it as a P0 to
stop users picking an unsupported option, aws#694/aws#696 added it back with
semanticOverride, and aws#713 reverted both as premature. aws#676 tracks doing it
properly. The CDK keeping CUSTOM in its enum without a configuration field is
the same hole, not a licence.

So both forms are rejected again, now with an error that says why and points
at aws#676. The one thing kept from the reverted commit: memory validation errors
name the offending field, since issue.path was being dropped.
@notgitika notgitika mentioned this pull request Aug 18, 2026
Open
notgitika added a commit to notgitika/agentcore-cli that referenced this pull request Aug 19, 2026
@notgitika
revert: drop CUSTOM memory strategy from "project add memory"
d97e77a 
Reverts 87be86e. I added CUSTOM because the CDK schema already had it in
MemoryStrategyTypeSchema, which turns out to be the argument PR aws#694 made --
and aws#713 reverted a day later.

The CLI has removed CUSTOM twice on purpose. Offering the type without
somewhere to put its extraction configuration is aws#241 ("select custom memory
strategy, note there is no option to add prompts"); aws#266 removed it as a P0 to
stop users picking an unsupported option, aws#694/aws#696 added it back with
semanticOverride, and aws#713 reverted both as premature. aws#676 tracks doing it
properly. The CDK keeping CUSTOM in its enum without a configuration field is
the same hole, not a licence.

So both forms are rejected again, now with an error that says why and points
at aws#676. The one thing kept from the reverted commit: memory validation errors
name the offending field, since issue.path was being dropped.
notgitika added a commit to notgitika/agentcore-cli that referenced this pull request Aug 20, 2026
@notgitika
revert: drop CUSTOM memory strategy from "project add memory"
d88f88b 
Reverts 87be86e. I added CUSTOM because the CDK schema already had it in
MemoryStrategyTypeSchema, which turns out to be the argument PR aws#694 made --
and aws#713 reverted a day later.

The CLI has removed CUSTOM twice on purpose. Offering the type without
somewhere to put its extraction configuration is aws#241 ("select custom memory
strategy, note there is no option to add prompts"); aws#266 removed it as a P0 to
stop users picking an unsupported option, aws#694/aws#696 added it back with
semanticOverride, and aws#713 reverted both as premature. aws#676 tracks doing it
properly. The CDK keeping CUSTOM in its enum without a configuration field is
the same hole, not a licence.

So both forms are rejected again, now with an error that says why and points
at aws#676. The one thing kept from the reverted commit: memory validation errors
name the offending field, since issue.path was being dropped.
notgitika added a commit to notgitika/agentcore-cli that referenced this pull request Aug 21, 2026
@notgitika
revert: drop CUSTOM memory strategy from "project add memory"
eb1a38d 
Reverts 87be86e. I added CUSTOM because the CDK schema already had it in
MemoryStrategyTypeSchema, which turns out to be the argument PR aws#694 made --
and aws#713 reverted a day later.

The CLI has removed CUSTOM twice on purpose. Offering the type without
somewhere to put its extraction configuration is aws#241 ("select custom memory
strategy, note there is no option to add prompts"); aws#266 removed it as a P0 to
stop users picking an unsupported option, aws#694/aws#696 added it back with
semanticOverride, and aws#713 reverted both as premature. aws#676 tracks doing it
properly. The CDK keeping CUSTOM in its enum without a configuration field is
the same hole, not a licence.

So both forms are rejected again, now with an error that says why and points
at aws#676. The one thing kept from the reverted commit: memory validation errors
name the offending field, since issue.path was being dropped.
notgitika added a commit to notgitika/agentcore-cli that referenced this pull request Aug 21, 2026
@notgitika
revert: drop CUSTOM memory strategy from "project add memory"
5bb84e4 
Reverts 87be86e. I added CUSTOM because the CDK schema already had it in
MemoryStrategyTypeSchema, which turns out to be the argument PR aws#694 made --
and aws#713 reverted a day later.

The CLI has removed CUSTOM twice on purpose. Offering the type without
somewhere to put its extraction configuration is aws#241 ("select custom memory
strategy, note there is no option to add prompts"); aws#266 removed it as a P0 to
stop users picking an unsupported option, aws#694/aws#696 added it back with
semanticOverride, and aws#713 reverted both as premature. aws#676 tracks doing it
properly. The CDK keeping CUSTOM in its enum without a configuration field is
the same hole, not a licence.

So both forms are rejected again, now with an error that says why and points
at aws#676. The one thing kept from the reverted commit: memory validation errors
name the offending field, since issue.path was being dropped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jesseturner21 jesseturner21 jesseturner21 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/l PR size: L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aidandaly24 @jesseturner21