Skip to content

Warn on invalid responsive resource ranges - #11

Merged
nicodes merged 3 commits into
mainfrom
issue-151-responsive-validation
Sep 13, 2026
Merged

Warn on invalid responsive resource ranges#11
nicodes merged 3 commits into
mainfrom
issue-151-responsive-validation

Conversation

@nicodes

@nicodes nicodes commented Sep 12, 2026

Copy link
Copy Markdown
Member

Self-verification evidence (Team No Review)

Issue: https://github.com/aviorstudio/fieldsofrevik/issues/151 — behavior layer stacked on #10. No review requested.

  • Source: aviorstudio/gd-responsive, issue-151-responsive-validation, exact head c6e3da096caf5af21767e72f635cb598d473e5f9; baseline/known-good valid resource from 73752cef4ca83ddd9691cf0f80e54a3e469a5b5d.
  • Live editor validation — PASS: Godot 4.7.2 editor process reached 21 assertions. Valid control had zero warnings; invalid min_content_width > max_content_width, min_scale > max_scale, and mobile_breakpoint >= tablet_breakpoint produced three field-specific warnings. All six artist edits emitted changed and retained their exact values.
  • Save/reopen/recovery — PASS: invalid .tres saved and reopened with all values/warnings intact; layout warning propagation remained finite/stable; correcting only the conflicting minima/mobile breakpoint cleared resource and node warnings; recovered resource saved and reopened valid.
  • Installed editor lifecycle — PASS: the exact 28-file package rendered the warning in the Inspector, hid it live after recovery, survived restart, removed its owned UID-form autoload on disable/restart, and preserved the consumer-owned GdResponsive autoload.
  • Package/web — PASS: exact-head CI ZIP SHA-256 c3674be9a8b790bb91397b7e3f317ee20c4ccd64b0d2aa2f4d0c68ad1575b3bf; installed-tree SHA-256 a94ef4aa969b33d6f7a8393df7985363af28f5940139ec314a19cc6782db0a82; web export passed. Personal playwright-cli 0.1.18 check at 960×720 loaded the packaged Godot export with zero console errors and visibly rendered GD Responsive Web Smoke PASS | device=0 | width=480.
  • Browser evidence: Godot web packaged smoke PASS
  • Exact-head CI — PASS: https://github.com/aviorstudio/gd-responsive/actions/runs/34739398790
  • Commands: strict suite and seven negative controls via ./tests/test.sh; closed package build/verify; clean packaged editor enable/restart/validation/disable/restart; Godot 4.7.2 Web export; playwright-cli -s=gd-responsive open/reload/screenshot against local exact packaged export.
  • Tool-dependency finding — PASS / no blanket engine claim: @tool config, layout, inspector plugin, serialization and reopen all execute under the real 4.7.2 editor. The reproduced shutdown diagnostics are narrowly type-allowlisted only for scripted editor exit and are not attributed as a Godot defect.
  • Security/performance: no new external input or workload limits; no heavy benchmark; artist values are never silently retuned. Untested until delivery: GitHub Release/GDAM registry bytes and registry reinstall, which block issue closure.

Correction — issue #151 stack replay

The native stack merge rebased this layer from 4b02736cf3bfdb88044760d6cff08fc9ff3ad743 to c6e3da096caf5af21767e72f635cb598d473e5f9. git range-diff showed all three commits as equivalent (=), and refreshed exact-head CI passed: 7 restored controls, 6 scripts, 21 editor assertions, 28-file package, Inspector validation, installed lifecycle, and web export. The head, run URL, package SHA, and screenshot URL above replace the superseded pre-rebase identities; installed-tree SHA remains unchanged.

@nicodes
nicodes added this pull request to stack #12 September 13, 2026 05:01
Base automatically changed from issue-151-studio-engineering to main September 13, 2026 05:04
@nicodes
nicodes force-pushed the issue-151-responsive-validation branch from 4b02736 to c6e3da0 Compare September 13, 2026 05:04
@nicodes
nicodes merged commit e624c82 into main Sep 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant