Allow PKCE code_verifier in exchange_auth_code_for_tokens - #308
Closed
mellowfish wants to merge 1 commit into
Closed
Allow PKCE code_verifier in exchange_auth_code_for_tokens#308mellowfish wants to merge 1 commit into
mellowfish wants to merge 1 commit into
Conversation
Author
|
Closing in favor of a more holistic approach to PKCE support across multiple endpoints. |
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Updated
exchange_auth_code_for_tokensto accept a PKCEcode_verifier(and any other optional params).References
Fixes #305
Testing
It doesn't look like there are any tests for this endpoint, but I can confirm this code works locally with our tenant which requires PKCE.
Checklist