Repository navigation
fix(cli): map syntext IndexNotFound and auto-build content index in query code - #243
Merged
Merged
Conversation
…uery code - Map IndexError::IndexNotFound in From<IndexError> so a missing index surfaces the friendly hint instead of leaking syntext's internal `st index` error as an internal bug - query code now builds the content index automatically when missing
Auto-building made the command silently slow. Catch IndexNotFound and point at `atomic vault query index` (enrich also builds it). Keep the From<IndexError> fix so the missing index surfaces as IndexNotFound instead of leaking syntext's `st index` internal error.
The intent-attest external-signer tests redirect the config area via ATOMIC_CONFIG_DIR and fail on Windows with 'identity not found' — dirs::home_dir() there resolves the profile known-folder, not HOME, so env redirection never applied. Resolve the identity store the same way atomic-config resolves config.toml (ATOMIC_CONFIG_DIR wins, then ~/.atomic), making the documented knob cover the whole config area.
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
atomic vault query codefailed with an "Internal error... runst index" message when the content index didn't exist.stis syntext's own CLI — its error leaked through because theFrom<IndexError>impl didn't map syntext 1.4'sIndexError::IndexNotFoundvariant (it only mappedIndexError::Io(NotFound)).Changes
IndexError::IndexNotFound(_)→ContentSearchError::IndexNotFoundso users get the friendly hint instead of an "internal bug" reportquery codenow auto-builds the content index (with spinner) when missing, mirroring whatenrichphase 8 doesTesting
Verified on a scratch repo: fresh index build on first
query codeinvocation, subsequent searches work.