Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Merge conflicts view destroys the editor's default marker layer #598

Description

@maxbrunsfeld

It looks like when the EditorConflictController unmounts, it destroys the TextEditor's default marker layer. This puts the editor into a bad state where subsequent attempts to decorate markers fail.

I don't remember what the problem was with adding a new layer, but in the meantime, we could just remove the call to this.layer.destroy().

/cc @smashwilson

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions