fix: auto heading numbering respects manually numbered headings - #7
Merged
Merged
Conversation
Documents whose headings already carry numbers ('## 1. Executive
Summary', '### 3.1 Storage') rendered doubled/offset numbers with
numberedHeadings on (e.g. '1.2 1. Executive Summary'). Self-numbered
headings are now detected (startsWithManualNumber — Latin +
Arabic-Indic digits, '1.'/'2)'/'3.1'/glued '1.Intro'; year-like
'2024 Report' and '3D' stay untouched) and become fully transparent
to the auto counters — no prefix, no increment, no child reset — in
both the CSS-counter preview and the baked-number PDF export, so the
two always agree. Covered by unit tests and verified end to end
against the reporting document that hit the bug.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents whose headings already carry numbers ('## 1. Executive Summary', '### 3.1 Storage') rendered doubled/offset numbers with numberedHeadings on (e.g. '1.2 1. Executive Summary'). Self-numbered headings are now detected (startsWithManualNumber — Latin + Arabic-Indic digits, '1.'/'2)'/'3.1'/glued '1.Intro'; year-like '2024 Report' and '3D' stay untouched) and become fully transparent to the auto counters — no prefix, no increment, no child reset — in both the CSS-counter preview and the baked-number PDF export, so the two always agree. Covered by unit tests and verified end to end against the reporting document that hit the bug.
Summary
Type of Change
feat— new featurefix— bug fixdocs— documentation onlyrefactor— code change that neither fixes a bug nor adds a featurechore— tooling / maintenancetest— adding or updating testsperf— performance improvementci— CI / build changesScreenshots
Checklist
npm run typecheckpassesnpm run lintpassesnpm run buildpassesany, immutable updates, logical CSS)console.log(uses@/lib/logger)