fix: define window.va queue stub on marketing pages so custom events … - #11
Merged
Merged
Conversation
…queue reliably Marketing pages fire custom events by calling window.va directly (they ship no framework JS). The deferred /_vercel/insights/script.js defines window.va only once it loads, so an early click could drop the event. Add the standard va queue stub (same one @vercel/analytics injects) up front in the enhancement script: events always queue and the real script drains window.vaq once analytics is provisioned.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…queue reliably
Marketing pages fire custom events by calling window.va directly (they ship no framework JS). The deferred /_vercel/insights/script.js defines window.va only once it loads, so an early click could drop the event. Add the standard va queue stub (same one @vercel/analytics injects) up front in the enhancement script: events always queue and the real script drains window.vaq once analytics is provisioned.
Summary
Type of Change
feat— new featurefix— bug fixdocs— documentation onlyrefactor— code change that neither fixes a bug nor adds a featurechore— tooling / maintenancetest— adding or updating testsperf— performance improvementci— CI / build changesScreenshots
Checklist
npm run typecheckpassesnpm run lintpassesnpm run buildpassesany, immutable updates, logical CSS)console.log(uses@/lib/logger)