Repository navigation
fix(mobile): expo-widgets 58.0.18 compiles on Android - #25
Merged
Merged
Conversation
expo-widgets 58.0.18 still imports the peek library under its old io.github.jakex7.peek package in six places, while its Gradle build depends on io.github.expo.peek 0.3.2, which ships the same classes under the renamed package. The personal APK build failed with unresolved references, so release v0.1.1-atli.1 did not publish. The fork's patch adds the import rename to upstream's expo-widgets patch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Skald review statusSkald: review ready (success) at review state version 10, head BlockingNothing is holding this pull request open. ClearedNothing is cleared at this epoch. Blocking: 0. Advisory: 0. Cleared: 0. Fenced: 0. Review rounds
|
![atli-skald[bot]](https://avatars.githubusercontent.com/in/4512341?s=60&v=4){kind=small}
There was a problem hiding this comment.
Skald review is clean
Reviewed head 0bd0df966206d4055d9d205c0f9caac4f0cbc3ec against base atli (67bf4e6edca77465184a9d19f007e04f95f133ef).
First round
Standing summary: open
Review details
Completed reviewers:
- architecture (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
- security (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
- testing (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
v0.1.1-atli.1release failed in the personal Android APK build, so nothing was published. Kotlin couldn't resolveio.github.jakex7.peek.*inexpo-widgets.The cause is in
expo-widgets58.0.18, which upstream adopted in pingdotgg#20067. Six of its Android imports still use the peek library's old package,io.github.jakex7.peek. Itsbuild.gradledepends onio.github.expo.peek:peek-emittables:0.3.2, and those artifacts ship the same classes (PeekNotificationViews,PeekNotificationSizes,setPeekContent,peekEmittableNotificationViews) under the renamedio.github.expo.peekpackage. Upstream doesn't hit this because its Android CI mirrors the Play APK instead of compiling.The fix adds that import rename to upstream's
patches/expo-widgets@58.0.18.patch; upstream's existing hunks are unchanged. A comment inpnpm-workspace.yamlmarks it as a fork addition for the next sync.Verified locally: after
expo prebuild,./gradlew :expo-widgets:compileReleaseKotlinsucceeds. I built the default variant, because the personal variant needs the release signing key just to configure.🤖 Generated with Claude Code