Skip to content

ci(fork): stop running upstream's CI; gate atli on the fork's own tests - #23

Merged
gabynevada merged 3 commits into
atlifrom
ci/fork-check
Oct 16, 2026
Merged

ci(fork): stop running upstream's CI; gate atli on the fork's own tests#23
gabynevada merged 3 commits into
atlifrom
ci/fork-check

Conversation

@gabynevada

@gabynevada gabynevada commented Oct 16, 2026

Copy link
Copy Markdown

GitHub paused all Actions on this fork on 2026-10-14 ("Workflows are not currently being run on this fork due to the scale of GitHub Actions usage"). The fork was running upstream's full CI, about 46 job-minutes, on every push and pull request. Upstream already runs that suite on every upstream commit.

What changes

  • fork-ci.yml: a single job named Check, which is the name the atli ruleset and the release guard already require. scripts/fork-check.ts does three things:

    • finds the upstream commit the branch builds on (the merge-base with pingdotgg/t3code main);
    • confirms upstream's own Check passed on that commit;
    • runs every test file the fork added or changed since that commit, inside the package that owns it.

    The job then lints (vp check) and typechecks (vpr typecheck) the whole repo. Locally the fork tests take about 3.7 minutes (68 files, about 1,700 tests).

  • fork-full-suite.yml: runs every package's tests on 6 runners. fork-server-release.yml now runs it on the commit it publishes, and publish waits for it to pass. It can also be dispatched by hand after a large update.

  • ci.yml: restored to upstream's copy, so upstream updates stop conflicting on it. The CI and Mobile Android APK workflows are now disabled on the fork. Nothing that isn't a fork workflow remains active.

  • Runbook:

    • freeze the newest upstream commit whose CI passed;
    • disable every upstream workflow, including ones an update adds;
    • a new section explaining why.

Still needed: a repository admin has to lift GitHub's pause from the banner on the Actions tab. Until then, no workflow runs, including this PR's Check.

🤖 Generated with Claude Code

@gabynevada @claude
ci(fork): stop running upstream's CI; gate atli on the fork's own tests
f6dca84 
Running upstream's full CI on every fork push and pull request (about 46
job-minutes each) got the fork's Actions paused by GitHub for usage volume.
Upstream already runs that suite on every upstream commit.

- fork-ci.yml: one `Check` job (the name the atli ruleset and the release
  guard require). scripts/fork-check.ts confirms the upstream commit the branch
  builds on passed upstream's own `Check`, then runs every test file the fork
  added or changed since that commit in its package; the job then lints and
  typechecks everything.
- fork-full-suite.yml: every package's tests, run by fork-server-release.yml on
  the commit it publishes, and dispatchable after a large update.
- ci.yml goes back to upstream's copy, so updates stop conflicting on it; the
  workflow stays disabled on the fork.
- Runbook: freeze the newest upstream commit whose CI passed, disable every
  upstream workflow (including ones an update adds), and a section on why.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@atli-skald

atli-skald Bot commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Skald review status

Skald: findings need a response (failure) at review state version 38, head 29bbfb14571c477aab0460308dc7fa3c6c1ebefb.

Blocking

  • .github/workflows/fork-ci.yml:58 — Fork CI never installs the Playwright Chromium binary or its dependencies before executing selected tests. Installing playwright-core and Electron does not install the Chromium revision that chromium.launch() uses. — nobody has answered it
  • scripts/fork-check.ts:202 — Git C-quotes that path, including surrounding double quotes; the parser neither requests NUL-delimited raw paths nor decodes quoting. TEST_FILE therefore rejects the record because it ends in a quote rather than .ts. — nobody has answered it
  • scripts/fork-check.ts:22 — TEST_FILE accepts only .test.ts and .test.tsx, so existing .test.js and .test.mjs suites are silently discarded before either grouping or orphan detection. — nobody has answered it

Cleared

Nothing is cleared at this epoch.

Blocking: 0. Advisory: 3. Cleared: 0. Fenced: 0.
Response required: 3.

Review rounds
  • f6dca84ec1d5408e72fa836f990ee71f06304bf5
  • cc017de28e633d0be74a4b0cc5b2d4c140a3d978
  • 29bbfb14571c477aab0460308dc7fa3c6c1ebefb

atli-skald[bot]
atli-skald Bot reviewed Oct 16, 2026
View reviewed changes

@atli-skald atli-skald Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skald review findings

Reviewed head f6dca84ec1d5408e72fa836f990ee71f06304bf5 against base atli (ea0fb6ec8f3578db7c6e6b63dacc9310ae686cb2).

First round

Standing summary: open

Review details

Completed reviewers:

  • architecture (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
  • frontend (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
  • security (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
  • testing (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)

Comment thread scripts/fork-check.ts Outdated
Comment thread .github/workflows/fork-ci.yml
@gabynevada @claude
fix(fork): fork check selects every test extension Vitest runs
cc017de 
Skald: .test.js and .test.mjs suites (apps/desktop) were dropped before
grouping or orphan detection.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
atli-skald[bot]
atli-skald Bot reviewed Oct 16, 2026
View reviewed changes

@atli-skald atli-skald Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skald review findings

Reviewed head cc017de28e633d0be74a4b0cc5b2d4c140a3d978 against base atli (ea0fb6ec8f3578db7c6e6b63dacc9310ae686cb2).

New 1 · Carried 2 · Cleared 0 · Verified 0 since round f6dca84

Standing summary: open

Review details

Completed reviewers:

  • architecture (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
  • architecture (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
  • frontend (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
  • frontend (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
  • security (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
  • security (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
  • testing (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
  • testing (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)

Comment thread scripts/fork-check.ts Outdated
@gabynevada @claude
fix(fork): fork check reads raw NUL-separated paths from git
29bbfb1 
Skald: git C-quotes unusual paths in --name-only and ls-files output, so a
quoted test path would not match the test file pattern.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
atli-skald[bot]
atli-skald Bot reviewed Oct 16, 2026
View reviewed changes

@atli-skald atli-skald Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skald review findings

Reviewed head 29bbfb14571c477aab0460308dc7fa3c6c1ebefb against base atli (ea0fb6ec8f3578db7c6e6b63dacc9310ae686cb2).

New 1 · Carried 2 · Cleared 0 · Verified 0 since round cc017de

Not shown inline

These findings are listed here rather than on a line of this pull request: some have no line to attach to, and advisory ones are never threaded. Each row says which.

  • scripts/fork-check.ts:22 — TEST_FILE accepts only .test.ts and .test.tsx, so existing .test.js and .test.mjs suites are silently discarded before either grouping or orphan detection. — location changed since the review (anchor disappeared)

Standing summary: open

Review details

Completed reviewers:

  • architecture (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
  • architecture (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
  • architecture (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
  • frontend (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
  • frontend (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
  • frontend (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
  • security (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
  • security (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
  • security (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
  • testing (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
  • testing (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)
  • testing (hub-dispatch-v2:codex:gpt-6.1-sol:medium:9441865e1d0f674b)

@gabynevada
gabynevada merged commit 745f78d into atli Oct 16, 2026
1 of 2 checks passed
gabynevada added a commit that referenced this pull request Oct 16, 2026
@gabynevada @claude
Merge atli into update/upstream-e6bbfdb9ffe8
0ef91d5 
Brings in the fork CI change (#23). ci.yml takes upstream's copy
(cfafb4b) unchanged: the fork no longer edits or runs it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@gabynevada gabynevada mentioned this pull request Oct 16, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atli-skald atli-skald[bot] atli-skald[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gabynevada