Fix Steam library Grant Access and refresh dependencies - #25
Merged
Conversation
The file chooser returns a document-portal path instead of the host library from Steam, so exact path matching rejected a valid grant. Treat a selected folder with steamapps as the library and map it back to the inaccessible VDF entry.
Refresh Cargo.lock and Flatpak cargo-sources, bump dirs to 7, and update 7-Zip, HDiffPatch, GTK, libadwaita, and the Flatpak builder action. Keep the GNOME 50 runtime; 51 is not released yet.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/data/SteamLibraryCargo.lockand Flatpak offline cargo sourcesdirsto 7 and pin 7-Zip 26.03, HDiffPatch 5.1.3, GTK 4.22.5, libadwaita 1.9.3, and flatpak-builder action v6.8Why
Grant Access compared the host path from
libraryfolders.vdfwith the folder returned by the sandboxed file chooser. The portal path is not/data/SteamLibrary, so a correct selection was rejected with "Selected folder does not match the required Steam library".Impact
Users can grant access to a Steam library outside the default Flatpak filesystem paths (
/mnt,/media, home Steam dirs) and continue setup. Packaging pins stay current and reproducible.Validation
cargo fmtcargo clippy --locked --all-targets -- -D warningscargo test --locked(359 lib tests, plus CLI/e2e/cargo-sources)python3 build-aux/check-cargo-sources.py(230 offline Cargo sources)