fix(release): CLI archive builds again after the upstream sync - #79
Merged
Merged
Conversation
Upstream's Effect upgrade left pnpm's placeholder text as the allowBuilds value for msgpackr-extract. build-cli-archive.ts decodes allowBuilds as booleans, so every archive build failed with 'Expected boolean'. Decline the build, matching the other optional native accelerators, and run the release build on pull requests that touch pnpm-workspace.yaml. Model: Claude Fable 5.1 via Claude Code.
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The fork release build fails on
mainwithSchemaError: Expected boolean. Upstream's Effect upgrade (pingdotgg#12326, pulled in by the 2026-09-18 sync) left pnpm's placeholder text,set this to true or false, as theallowBuildsvalue formsgpackr-extractinpnpm-workspace.yaml.scripts/build-cli-archive.tsdecodesallowBuildsas booleans, so both archive builds stop right after staging. No release can be cut until this is fixed.Change
Set
msgpackr-extract: false, matching the other optional native accelerators such asbufferutil. msgpackr falls back to its JavaScript implementation. Also run the fork release build on pull requests that touchpnpm-workspace.yaml, so this PR proves itself and the next such breakage shows up before merge. The lockfile is unchanged undervp install --frozen-lockfile.Model: Claude Fable 5.1 via Claude Code.