Repository navigation
For some reason, the mod causes gradual FPS drop #56
Description
Recently, me and my friends realized that whenever we stay on the level for long time (ESPECIALLY BAD on Sky Meadow level), the FPS starts to drop and the game eventually become unplayable.
(it drops to the level of screen stops frequently, my PC spec is i5-10600K, RTX 3060 Ti, 16GB Memory)
I tried the game without any mods installed (launched through Steam), and I didn't have any problem. I immediately knew that this has to be with the mods I installed. So, I tried toggling off every mods one by one and eventually found out that your MiniMapMod was the reason.
I was wondering if the toggling the minimap off in-game fix the issue, so I gave it a go. And the result was that toggling off the minimap in-game normalized the FPS immediately.
I can replicate the issue so If you want to see how it happens, contact me pls [kralkral#8591]
Activity
artyredd commentedon Mar 28, 2022
How... how long are we talking here? I have very close hardware to you and I play test this on a dual core/1050ti and have about 60 fps even with low end hardware.
Could you send me information on how to replicate this, aka a time to stay on certain stages?
I will also need your entire mod list and the configuration file for minimapmod.
Thanks,
Arty
Alphaccca commentedon Mar 28, 2022
This also happens on my PC and sky meadow is where it gets worse. Playing for 5-10 minutes will plummet my fps from 70 to 30 ish. Closing and opening minimap will reset the fps.
artyredd commentedon Mar 28, 2022
Hi @Alphaccca, could you provide me with a copy of your minimap config, and your entire mod list please?
Thanks,
Arty
Alphaccca commentedon Mar 28, 2022
R2modman profile code: mzveLYQ6go
Alternatively
Pastebin: https://pastebin.com/uRxQcMKr
artyredd commentedon Mar 30, 2022
@kral6974 , could you also provide your mod list and config so I can cross reference it with @Alphaccca's list?
Thanks,
Arty
kral3000 commentedon Mar 31, 2022
oops sorry I was busy at the moment
My code: tpWWPNs5IN
kral3000 commentedon Mar 31, 2022
SO, when I first enter the Sky Meadow stage, I get around 150-180 with little mobs.
after 4-5 minutes passed, my FPS indicator is showing around 110-150 even with little mobs
and it gets worse quicker after 5 minute time stamp.
It eventually breaks the 100 line and I can feel the framedrop because I am using 144hz monitor
The "it drops to the level of screen stops frequently" I''ve mentioned in the original post could be a little different story because it was with 2 other players (multiplayer) and was like 15th stage or something
artyredd commentedon Mar 31, 2022
Thanks,
I was having trouble reproducing this issue so I'll try using your code to reproduce this.
ohIkick commentedon May 3, 2022
I looked at the log file and found a piece of information.
[Debug :Mini Map Mod] Creating Minimap object
[Debug :Mini Map Mod] Finished creating Minimap
[Error : Unity Log] Object PodGroundImpact(Clone) (UnityEngine.GameObject) should not be instantiated by means other than EffectManager.SpawnEffect. This WILL result in an NRE!!! Use EffectManager.SpawnEffect or don't use EffectComponent!!!!!
[Warning: Unity Log] Animator.GotoState: State could not be found
[Warning: Unity Log] Invalid Layer Index '-1'
[Warning: Unity Log] Animator.GotoState: State could not be found
[Warning: Unity Log] Invalid Layer Index '-1'
Not this message when I disable this mod.Maybe that's the problem?
cypressious commentedon Jun 6, 2022
I noticed the same. Pressing M twice to toggle the map off and on seems to bring FPS back to normal level.
Could it have something to do with the floating rocks that appear as white dots? Maybe more and more of them spawn continously which leads to a memory leak of some sort?
artyredd commentedon Feb 11, 2023
Took a look and play tested it, seems the floating rocks might be forcing a re-scan of the scene when they disappear since they're enemies.
GlobalEventManager.onCharacterDeathGlobal += (x) => ScanScene();I'll have to see if there is something i can do to fix it, only issue is the mod is made to be version stable and I try not to rely on too many implementation details and this was the easiest hook that would get enemies workin.
I'm prett busy with stuff, but when I get around to it, or the next time this mod version breaks, I'll probably fix it