feat(ui): detail consistency — inline errors in editors, unified phrasing (v1.17 G) - #47
Merged
Merged
Conversation
8 tasks done
argszero
added a commit
that referenced
this pull request
Sep 29, 2026
…324) ui/README.md:90 (the inline-components section) said an inlineForm `opts.validate` error is surfaced as "toast + 重新聚焦". That was true at birth (990cd5a, #41) but 2d492ee (#47) changed the code to `setFieldError(input, err)` and added the `## 一致性约定` section, which states at line 133 that inline-edit validation goes through `setFieldError` and explicitly does not use a toast. Only line 90 was left behind, so the same file contradicted itself and the code. Fix the wording to match line 133 and the implementation; no behaviour change, no new i18n keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rant
2026-08-17T16:57:17(UI/UE 多角度深化优化), item G — 细节一致性 (final item): consistency audit of number/amount formatting, 已用/额度 display, button sizing, and inline-editor error handling.Audit results (already consistent ✓)
D.fmt()(thousand separators / 2 decimals) — sidebar balance, stat cards, tables, wallet all uniform;padding:4px 10px;font-size:12px).Fixes applied
inlineFormvalidate failure switched from toast-only tosetFieldError(red border + inline text, auto-clear) — covers API Key rename, operator topup, member topup;Acceptance
All 7 items (A–G) of rant 16:57:17 now satisfied — PRs #41–#47, docs v1.17.
Tests
node --checkon app.js — syntax OKcargo test— 1 passedcargo fmt --check— clean