fix(ui): drop dead internal pointers from the user-visible copy - #224
Merged
Merged
Conversation
Two rendered strings in `ui/js/i18n.js` point at material that the 2026-08-22 docs flattening deleted: - `wallet.raise.sub` / `admin.raise.sub` carry the requirement id `US-20`. Commit 6d87213 (#119) rewrote docs/user-stories.md into a current-state doc and dropped every `US-<n>` id, so `US-20` resolves nowhere: `grep -rn 'US-[0-9]' docs/ README.md README.en.md` is empty at HEAD. Every other `US-` id in the repo lives in a code comment or in ui/README.md; these were the only ones shown to users. - `mk.detail.routeVal` cites 「架构 v0.2 路由策略」. The same commit deleted the `4.2.1 路由与故障转移策略(v0.2)` section from docs/architecture.md, and that file has no version stamp left. One root cause, two pointer shapes: #179 fixed the `§N` references the flattening broke and #216 the `file:line` ones, but the `name + stamp` shape (`US-20`, `v0.2`) was never audited. The pack values are now plain prose (both sentences were already self-contained), each edited static fallback in ui/index.html is kept byte-equal to its pack value, and the three ui/README.md lines that cited the deleted section are re-pointed at the section that carries the content today (docs/architecture.md §3, the `router.rs` row), in the style of #179. `ui/` text only: no Rust change, no i18n key added or removed (786/786 before and after), no new T() call sites or data-i18n attributes. i18n.js content changed, so its cache-bust is bumped (20260912-5 -> 20260914-4). Co-authored-by: argszero <argszero@argszerodeMac-mini.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Six user-visible strings still point at material that the 2026-08-22 docs flattening (
6d87213, #119) deleted from this repo:i18n.jswallet.raise.sub(zh+en) + itsindex.htmlfallback(US-20)docs/user-stories.mddefines noUS-<n>idsi18n.jsadmin.raise.sub(zh+en) + itsindex.htmlfallback(US-20:…)i18n.jsmk.detail.routeVal(zh+en)(架构 v0.2 路由策略)docs/architecture.mdhas nov0.2section#119("concise current-state docs") rewrote both user-facing docs: it dropped everyUS-<n>id fromdocs/user-stories.mdand deleted the4.2.1 路由与故障转移策略(v0.2)section fromdocs/architecture.md. Verified from the commit diff (- **US-20** 作为企业成员…,-#### 4.2.1 路由与故障转移策略(v0.2…).The pointer shapes audited so far stop short of this one: #179 repointed the dangling
§Nreferences, #216 thefile:linecitations. Thename + stampshape (US-20,v0.2) was never audited — and these are the only user-visible carriers of one, since every otherUS-id in the repo sits in a code comment or inui/README.md.Related Issue
None — filed from a recon sweep of the i18n copy carriers.
Changes
ui/js/i18n.js— drop the dead parentheticals from 6 live pack values (3 keys × zh/en). Each sentence was already self-contained.ui/index.html— keep the two editeddata-i18nfallbacks byte-equal to their pack value (the fallback is a second source of truth; fix(ui): replace code identifiers in the English stat-card copy #168 had to touch both files for the same reason), and bumpi18n.js?v=20260912-5→20260914-4.ui/README.md— re-point the 3 lines that cited 「架构 v0.2 路由策略」 at the section that carries that content today,docs/architecture.md§3 module table (router.rsrow), noting the old v0.2 / 4.2.1 provenance as docs: repoint 5 dangling section references to their current sections #179 did.admin.raise.demo/admin.org.demo/ops.demo(P2-C) — those keys are orphans, never rendered — and everyUS-/rantid inside comments, which is where the author keeps them.Tests
cargo test— 226 passed (unchanged; the i18n gate still sees 786/786 keys)cargo fmt --check/cargo clippy— no Rust file touchedc2106_dead_pointer_probe.py(21 assertions: 6 pack values, both fallbacks, fallback↔pack parity, prose preserved, pack counts, plus two positive controls proving the referents really are absent fromdocs/) — pre-change tree 8 red → post-change 21/21 greenUS-20→{C3, C7}; re-insert env0.2→{C4}; re-insert the stamp in the html fallback only →{C7, C7b}; revert one README re-point →{C17, C17b}Checklist
fix/)ui/text only)