fix(docker): remove invalid {{is_tag}} enable expr — latest always added - #118
Merged
Merged
Conversation
…ded (tag-only workflow)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix docker-publish failure on the v0.7.6 tag:
enable={{is_tag}}is not a valid expression in docker/metadata-action v5 — the action threwInvalid value for enable attribute:and the whole release job failed.Since the workflow now triggers only on
tags: ['v*'](PR #116, plusworkflow_dispatch), thelatesttag can simply always be added — it will only ever be refreshed by a version tag push (or an explicit manual dispatch), which is exactly the intended tag-driven release cadence.Changes
.github/workflows/docker-publish.yml:type=raw,value=latest,enable={{is_tag}}→type=raw,value=latestTests
v0.7.6tag after merge (the tag will point to the merge commit containing this fix, since Actions runs the workflow file from the triggering ref)