This repository was archived by the owner on May 14, 2026. It is now read-only.
chore: update static scheme - #588
Merged
Merged
Conversation
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
This was referenced Jun 27, 2024
crenshaw-dev
marked this pull request as ready for review
June 28, 2024 15:44
crenshaw-dev
added a commit
to crenshaw-dev/gitops-engine
that referenced
this pull request
Jul 1, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
to crenshaw-dev/gitops-engine
that referenced
this pull request
Jul 1, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> fix cherry-pick and test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
to crenshaw-dev/gitops-engine
that referenced
this pull request
Jul 1, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> fix cherry-pick and test Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Jul 2, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Jul 2, 2024
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix the following:
argoproj/argo-cd#13585
argoproj/argo-cd#15176
argoproj/argo-cd#16640
argoproj/argo-cd#17358
argoproj/argo-cd#17548
argoproj/argo-cd#17811
argoproj/argo-cd#18778
I've tested most of them manually. I don't think unit tests would be valuable. We can test old fields but not new ones.