Move Orca src files into the extension - #1151
Merged
Merged
Conversation
whitehawk
force-pushed
the
ADBDEV-6627
branch
from
December 10, 2024 00:31
ae7b1c5 to
9ce41b3
Compare
whitehawk
force-pushed
the
ADBDEV-6627
branch
from
December 10, 2024 01:17
9ce41b3 to
72aa781
Compare
whitehawk
force-pushed
the
ADBDEV-6627
branch
from
December 10, 2024 04:03
40fad64 to
bd7a81d
Compare
whitehawk
force-pushed
the
ADBDEV-6627
branch
from
December 10, 2024 05:29
baeebee to
cc07959
Compare
whitehawk
force-pushed
the
ADBDEV-6627
branch
from
December 11, 2024 02:56
23bf424 to
50468dd
Compare
whitehawk
force-pushed
the
ADBDEV-6627
branch
from
December 11, 2024 03:09
50468dd to
1a8399b
Compare
whitehawk
marked this pull request as ready for review
December 11, 2024 03:59
bimboterminator1
approved these changes
Dec 13, 2024
bimboterminator1
left a comment
Member
There was a problem hiding this comment.
Unit tests are passing, looks OK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move Orca src files into the extension
As a part of the bigger task of separating Orca into a Postgres extension, this
patch:
files into the extension.
extension already contains 'orca.c' file with hooks implementation, old 'orca.c'
is renamed to 'orca_entry.c'.
'gpcontrib/orca/Makefile'. It is mandated by the build infrastructure for
extensions (called PGXS). Old makefiles in 'gporca' and 'gpopt' are removed, as
no more needed. But CMake files are preserved, allowing to launch 'gporca' unit
tests.
by the code in the extension.
were used only for Orca code.
Note: 'src/tools/vagrant' also contains some references to Orca code, but it
looks too obsolete to be workable (as it references the old gporca git repo,
when Orca wasn't a part of the core). So it is left unchanged.