Rework gp_optimizer_functions.c to use runtime check of Orca's presence - #1126
Merged
Conversation
whitehawk
force-pushed
the
ADBDEV-6624
branch
from
November 19, 2024 00:42
0faa115 to
5d6af43
Compare
whitehawk
marked this pull request as ready for review
November 19, 2024 00:43
silent-observer
approved these changes
Nov 20, 2024
RekGRpth
reviewed
Nov 22, 2024
RekGRpth
reviewed
Nov 22, 2024
RekGRpth
reviewed
Nov 22, 2024
This comment was marked as resolved.
This comment was marked as resolved.
RekGRpth
reviewed
Nov 22, 2024
Author
done |
RekGRpth
reviewed
Nov 22, 2024
bimboterminator1
approved these changes
Nov 25, 2024
silent-observer
approved these changes
Nov 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework gp_optimizer_functions.c to use runtime check of Orca's presence
Problem:
Functions in gp_optimizer_functions.c had a compile-time dependency on Orca.
It introduced difficulties for moving Orca's functionality into a shared lib.
This patch:
'LibraryVersion()' into gp_orca shared lib.
'disable_xform()', 'gp_opt_version()'. Now they try to load the underlying
functions from a shared lib. Attempt to load a symbol from a shared lib is
wrapped into PG_TRY & PG_CATCH (with all necessary shenanigans), as the lib may
be missing. In this case we catch the error, and show an appropriate message.
Note: we do not move the wrapper's implementation into gp_orca extension, as
they are already a part of the system catalog. And we'd like to avoid changing
the system catalog.