Repository navigation
Add observable Comprehend prompt redaction - #669
Draft
QIU-Guanzong wants to merge 3 commits into
Draft
QIU-Guanzong wants to merge 3 commits into
QIU-Guanzong wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a JavaScript Comprehend redactor for #290. It plugs into RxJS pipelines and wraps the existing chat methods so prompt and message text are redacted before the endpoint is called.
The patch validates character ranges, merges overlaps, preserves Unicode code-point offsets, and stops the chain on detection errors, cancellation or timeout. Inputs are copied before asynchronous detection.
destroy()releases an owned SDK client and blocks later forwarding.Validation on
dd0632cb2d96ac8c2bf17bd0f19e6a737039b3a2:git diff --checkpassed.Reproduce from
JS/edgechains/arakoodev:Draft: acceptance evidence is incomplete. No real AWS or OpenAI service call was made, and the requested Loom recording is still missing. The README explains the offline fixture and the separately gated live mode. I asked about the demonstration requirement in this comment. No bounty claim is being made with this draft.
The AWS dependency requires Node 20+; validation used the local environment, not the repository's Node 18 workflow. Supported redaction paths are plain-text
promptandmessages[].content; metadata and tool arguments are outside scope. Comprehend may miss PII, so this is not a guarantee of anonymization.Developed and reviewed with AI assistance (Codex). The demo contains only synthetic input.
Offline review recording
31-second recording, full original video and execution logs. The recording shows the actual local fixture run followed by 34 passing tests. Idle intervals were removed; no execution frames were replaced. All nine uploaded asset sizes and SHA-256 digests were read back and matched locally. This remains offline evidence, not live AWS validation or the requested Loom submission.