Repository navigation
Add battery info - #85
Merged
Merged
Conversation
|
|
||
| def add_battery_info | ||
| ::Appium::Core::Device.add_endpoint_method(:get_battery_info) do | ||
| def get_clipboard(content_type: :plaintext) |
Member
Author
There was a problem hiding this comment.
oops, yup...
I forgot the change... (I've implemented the only iOS so far...)
KazuCocoa
commented
May 1, 2018
| def test_get_battery_info | ||
| stub_request(:post, "#{SESSION}/execute/sync") | ||
| .with(body: { script: 'mobile: batteryInfo', args: [{}] }.to_json) | ||
| .to_return(headers: HEADER, status: 200, body: { value: { state: 5, level: 0.5 } }.to_json) |
Member
Author
There was a problem hiding this comment.
If the value has status, then Ruby client raise parse response error.
I guess the implementation is https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#responses 's one.
test_get_battery_info ERROR (0.02s)
Selenium::WebDriver::Error::NoCollectionError: Selenium::WebDriver::Error::NoCollectionError: unknown error, status=2: nil
/Users/kazuaki/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/selenium-webdriver-3.11.0/lib/selenium/webdriver/remote/response.rb:69:in `assert_ok'
/Users/kazuaki/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/selenium-webdriver-3.11.0/lib/selenium/webdriver/remote/response.rb:32:in `initialize'
/Users/kazuaki/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/selenium-webdriver-3.11.0/lib/selenium/webdriver/remote/http/common.rb:81:in `new'
/Users/kazuaki/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/selenium-webdriver-3.11.0/lib/selenium/webdriver/remote/http/common.rb:81:in `create_response'
/Users/kazuaki/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/selenium-webdriver-3.11.0/lib/selenium/webdriver/remote/http/default.rb:104:in `request'
/Users/kazuaki/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/selenium-webdriver-3.11.0/lib/selenium/webdriver/remote/http/common.rb:59:in `call'
/Users/kazuaki/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/selenium-webdriver-3.11.0/lib/selenium/webdriver/remote/bridge.rb:164:in `execute'
/Users/kazuaki/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/selenium-webdriver-3.11.0/lib/selenium/webdriver/remote/oss/bridge.rb:579:in `execute'
/Users/kazuaki/.rbenv/versions/2.3.3/lib/ruby/gems/2.3.0/gems/selenium-webdriver-3.11.0/lib/selenium/webdriver/remote/oss/bridge.rb:267:in `execute_script'
/Users/kazuaki/GitHub/ruby_lib_core/lib/appium_lib_core/android/uiautomator2/device.rb:15:in `battery_info'
/Users/kazuaki/GitHub/ruby_lib_core/test/unit/android/device_test.rb:763:in `test_get_battery_info'
KazuCocoa
force-pushed
the
add_battery_info
branch
from
May 1, 2018 23:23
5abefa2 to
4736dd4
Compare
Member
Author
|
Applied every related PRs in my locale and ensured they worked fine. For Android, I changed emulator settings and made sure them. I'll merge after the CI 🍏 |
1 of 3 tasks
Member
Author
|
cc @mykola-mokhnach |
|
Thanks @KazuCocoa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add battery information accessors #83