feat!: drop CanRememberExtensionPresence - #1269
Conversation
|
wouldn't this be a breaking change? |
|
Yes, this will be. The next release will be a major version update, so I have created this change as well |
|
The test failures for Flutter was the downloaded contents was removed. can be ignored. I'll coordinate it later |
There was a problem hiding this comment.
Pull request overview
This PR completes the breaking-change removal of the legacy “remember extension presence” mechanism by deleting the CanRememberExtensionPresence protocol and removing the related WebDriver helper methods, while updating Android’s Common extension to no longer depend on that protocol.
Changes:
- Removed
assert_extension_exists/mark_extension_absencefromappium.webdriver.webdriver.WebDriver. - Deleted the
CanRememberExtensionPresenceprotocol. - Updated Android
Commonextension to dropCanRememberExtensionPresencefrom its base classes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| appium/webdriver/webdriver.py | Removes extension-presence helper methods and associated imports. |
| appium/webdriver/extensions/android/common.py | Drops CanRememberExtensionPresence from Common’s inheritance list. |
| appium/protocols/webdriver/can_remember_extension_presence.py | Deletes the protocol definition entirely. |
Suppressed comments (1)
appium/webdriver/webdriver.py:440
- After removing the extension-presence helpers, the driver still initializes
self._absent_extensions(and importsSet) but this attribute is now unused in the codebase. Keeping this dead state can confuse future maintenance and makes the feature removal incomplete; please remove_absent_extensionsinitialization and any now-unused typing imports.
def _add_commands(self) -> None:
# call the overridden command binders from all mixin classes except for
# appium.webdriver.webdriver.WebDriver and its sub-classes
# https://github.com/appium/python-client/issues/342
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
I'll prepare a major update with recent removals as well. |
#1267 (comment)