Skip to content

feat!: drop CanRememberExtensionPresence - #1269

Merged
KazuCocoa merged 3 commits into
masterfrom
remove-unused-class
Aug 8, 2026
Merged

feat!: drop CanRememberExtensionPresence#1269
KazuCocoa merged 3 commits into
masterfrom
remove-unused-class

Conversation

@KazuCocoa

Copy link
Copy Markdown
Member

@mykola-mokhnach

Copy link
Copy Markdown
Contributor

wouldn't this be a breaking change?

@KazuCocoa

Copy link
Copy Markdown
Member Author

Yes, this will be. The next release will be a major version update, so I have created this change as well

@KazuCocoa
KazuCocoa marked this pull request as draft August 4, 2026 21:39
@KazuCocoa
KazuCocoa marked this pull request as ready for review August 7, 2026 22:16
@KazuCocoa

Copy link
Copy Markdown
Member Author

The test failures for Flutter was the downloaded contents was removed. can be ignored. I'll coordinate it later

@KazuCocoa KazuCocoa changed the title feat: drop CanRememberExtensionPresence feat!: drop CanRememberExtensionPresence Aug 7, 2026
@KazuCocoa
KazuCocoa requested a lite review from Copilot August 7, 2026 23:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR completes the breaking-change removal of the legacy “remember extension presence” mechanism by deleting the CanRememberExtensionPresence protocol and removing the related WebDriver helper methods, while updating Android’s Common extension to no longer depend on that protocol.

Changes:

  • Removed assert_extension_exists / mark_extension_absence from appium.webdriver.webdriver.WebDriver.
  • Deleted the CanRememberExtensionPresence protocol.
  • Updated Android Common extension to drop CanRememberExtensionPresence from its base classes.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
appium/webdriver/webdriver.py Removes extension-presence helper methods and associated imports.
appium/webdriver/extensions/android/common.py Drops CanRememberExtensionPresence from Common’s inheritance list.
appium/protocols/webdriver/can_remember_extension_presence.py Deletes the protocol definition entirely.
Suppressed comments (1)

appium/webdriver/webdriver.py:440

  • After removing the extension-presence helpers, the driver still initializes self._absent_extensions (and imports Set) but this attribute is now unused in the codebase. Keeping this dead state can confuse future maintenance and makes the feature removal incomplete; please remove _absent_extensions initialization and any now-unused typing imports.
    def _add_commands(self) -> None:
        # call the overridden command binders from all mixin classes except for
        # appium.webdriver.webdriver.WebDriver and its sub-classes
        # https://github.com/appium/python-client/issues/342

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@KazuCocoa

Copy link
Copy Markdown
Member Author

I'll prepare a major update with recent removals as well.

@KazuCocoa
KazuCocoa merged commit e33851f into master Aug 8, 2026
12 of 17 checks passed
@KazuCocoa
KazuCocoa deleted the remove-unused-class branch August 8, 2026 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants