Skip to content

#392 fix & #418 fix - #423

Merged
TikhomirovSergey merged 2 commits into
appium:masterfrom
TikhomirovSergey:#392
Jun 22, 2016
Merged

#392 fix & #418 fix#423
TikhomirovSergey merged 2 commits into
appium:masterfrom
TikhomirovSergey:#392

Conversation

@TikhomirovSergey

@TikhomirovSergey TikhomirovSergey commented Jun 21, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

Change list

#392 fix & #418 fix

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

  • Now functionality should be like it is described by the wiki page. There are the positive and the negative tests which demonstrates it.
  • the possible dependency conflict was eliminated.

@TikhomirovSergey
#392 fix. Source code improvement
7513235 
Changes: Source code was improved.
TODO: Add tests
@TikhomirovSergey
#392 fix: New tests. #418 fix
9e1b968
@TikhomirovSergey

TikhomirovSergey commented Jun 21, 2016

Copy link
Copy Markdown
Contributor Author

@SrinivasanTarget @truebit
Please take a look at this PR :)

@TikhomirovSergey TikhomirovSergey added this to the 4.1.0 milestone Jun 21, 2016
@truebit

truebit commented Jun 22, 2016

Copy link
Copy Markdown
Contributor

#418 LGTM
I have tried #392 fix locally. now it works without html in OverrideWidget

@TikhomirovSergey

TikhomirovSergey commented Jun 22, 2016

Copy link
Copy Markdown
Contributor Author

Ok. Then I'm merging it.

@TikhomirovSergey
TikhomirovSergey merged commit f276c0f into appium:master Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug refactor

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@TikhomirovSergey @truebit