Repository navigation
#325: redesign of Android test - #353
Merged
TikhomirovSergey merged 8 commits intoApr 6, 2016
Merged
Conversation
It is needed to improve gesture tests
… made re-usable) It is needed to add swiping tests
Contributor
Author
|
@SrinivasanTarget Can you review this PR. @Jonahss @bootstraponline you can take a look at this PR too if you want :) |
| service.start(); | ||
|
|
||
| if (service == null || !service.isRunning()) | ||
| throw new RuntimeException("An appium server node is not started!"); |
Member
There was a problem hiding this comment.
This same beforeClass code is duplicated everywhere. maybe refactor this into a method that can be used across multiple classes?
Contributor
Author
|
@bootstraponline Thanks for the remork. It was improved |
| driver.startActivity("io.appium.android.apis", ".accessibility.AccessibilityNodeProviderActivity"); | ||
| Assert.assertEquals(driver.currentActivity(), ".accessibility.AccessibilityNodeProviderActivity"); | ||
| driver.startActivity("com.android.contacts", ".ContactsListActivity", "com.android.contacts", ".ContactsListActivity", false); | ||
| Assert.assertEquals(driver.currentActivity(), ".ContactsListActivity"); |
Member
There was a problem hiding this comment.
assertEquals should be statically imported so Assert. can be omitted.
Member
|
Code looks good to me. 👍 |
Contributor
Author
|
@bootstraponline The second code style issue was fixed. iOS tests are going to be redesigned the same way. This PR is the partial fix of #325 |
Member
|
LGTM |
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
Types of changes
Details