Repository navigation
#305 fix - #306
Merged
Merged
#305 fix#306
Conversation
Also - update to Selenium 2.50.0 - changes of HasAppStrings interface. The old 'getAppStrings()' was returbed with __Deprecated__ mark. New methods were renamed to 'getAppStringMap'
Contributor
Author
|
@imurchie @bootstraponline |
Contributor
|
👍 |
Contributor
Author
|
@rgonalo ok. Thanks for the reminding. |
Member
There was a problem hiding this comment.
ERROR_TEXT_WHEN_DEFAULT_APPIUM_NODE_IS_NOT_FOUND is too long. How about:
ERROR_NODE_NOT_FOUND
Member
|
code looks good to me 👍 |
Contributor
Author
|
@rgonalo @bootstraponline |
TikhomirovSergey
added a commit
that referenced
this pull request
Feb 1, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list: