Skip to content

#252 fix - #255

Merged
Jonahss merged 2 commits into
appium:masterfrom
TikhomirovSergey:#252-fix
Oct 16, 2015
Merged

Jonahss merged 2 commits into
appium:masterfrom
TikhomirovSergey:#252-fix

Conversation

@TikhomirovSergey

Copy link
Copy Markdown
Contributor

Change list:

  • 252 fix. It affects users that debug their scripts with Eclipse for Mac OS (Linux ?)

    Thanks to @pr4bh4sh for the clue.

  • the additional improvement
    Now processes which find default node.js and Appium node server are destroyed. I really don't guess that they can create zombie-processes, but it is better to be insured :)

@TikhomirovSergey

Copy link
Copy Markdown
Contributor Author

@Jonahss @pr4bh4sh @saikrishna321
Guys please look at this when you have some free time :)

@Jonahss

Jonahss commented Oct 16, 2015

Copy link
Copy Markdown
Member

Looks good to me :)

Jonahss added a commit that referenced this pull request Oct 16, 2015
@Jonahss
Jonahss merged commit b661581 into appium:master Oct 16, 2015
@Jonahss

Jonahss commented Oct 16, 2015

Copy link
Copy Markdown
Member

Oops, merged before the others had their say.
Uh, if @pr4bh4sh or @saikrishna321 have any comments we can rollback or add a patch. Sorry about that.

@TikhomirovSergey

Copy link
Copy Markdown
Contributor Author

It is ok. It is probably they have seen it :)

@saikrishna321

Copy link
Copy Markdown
Member

@Jonahss @TikhomirovSergey I did take a look at that .. Looks good to me 👍

@pr4bh4sh

Copy link
Copy Markdown

@Jonahss @TikhomirovSergey @saikrishna321 works on my machine too.

@TikhomirovSergey

Copy link
Copy Markdown
Contributor Author

@Jonahss @Jonahss @saikrishna321
Ok guys. There is one more major enhancement is coming ;). I think this fix will be published with the new feature.

@saikrishna321

Copy link
Copy Markdown
Member

@TikhomirovSergey what's the new feature ??

@TikhomirovSergey

Copy link
Copy Markdown
Contributor Author

@saikrishna321
It is
#228

@saikrishna321

Copy link
Copy Markdown
Member

👍

@saikrishna321

Copy link
Copy Markdown
Member

@TikhomirovSergey Wordpress app should b a good example to test this feature

(Android)
* Enter username and password and click on Signin Button

(IOS)
* Enter username , password.
* Enter the Site URL and then click on Singin Button

As this feature clearly is useful for identical apps on page object pattern with slight change in the flow.

Your thought ??

@TikhomirovSergey

Copy link
Copy Markdown
Contributor Author

@saikrishna321
Yep
Let discuss the feature that is coming out and related ideas here: #228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants