Repository navigation
[Enhancement] Spring configuration, beans and aspects vs EventFiringWebdriver #242
Description
The Selenium project has an interesting solution,
EventFiringWebDriver:
- http://www.seleniummonster.com/eventfiringwebdriver-and-event-listeners-in-selenium/
- http://www.abodeqa.com/2014/06/08/event-listeners-in-selenium-webdriver/
- and lots of staff that Google can find
Everything is cool but I think there are disadvantages for Appium users:
- this implementation restricts the using of mobile-specific functions till
AppiumDriver d = (AppiumDriver) eventFiringWebDriver.getWrappedDriver();The same is true for elements
MobileElement e = (MobileElement) ((WrapsElement) element).getWrappedDriver();- almost all interfaces which are nested in WebDriver has protected/private implementations here. So an end user has to duplicate the present code when there is need to extend it
What is supposed to be designed:
- it is supposed that the WebDriverEventListener interface will be reused. Also it would be cool if there were interfaces whose implementations allow to listen to (optionally) events of alerts, windows, contexts and so on.
- To design a solution which has linear architecture. It would be cool to use Spring & AspectJ here.
http://www.mkyong.com/spring3/spring-aop-aspectj-annotation-example/
Activity
Gpap84 commentedon Sep 15, 2015
Isn't it very strict to depend on Spring and AspectJ for proxifying objects for logging and other features?
TikhomirovSergey commentedon Sep 15, 2015
@GiannisPapadakis
Why not? :)
It would be good to have same AndroidDriver/IOSDriver or MobileElement with subclasses that also provide an ability to log events implicitly. Spring and AspectJ provide ability to create proxies of whole classes (not only interfaces) and implement that logging architecture in transparent and linear style.
There are probably another suitable tools...
Gpap84 commentedon Sep 15, 2015
It is ok with this solution of course. There are a lot of possibilities for Spring AOP to cover. You need of course to have a bean lifecycle. I could try some examples and review together if you want.
TikhomirovSergey commentedon Sep 15, 2015
@GiannisPapadakis
So do you consider that Spring could be more widely used in java_client? You are right definitely. The logging is just the most obvious capability :)
Gpap84 commentedon Sep 15, 2015
Of course it would be great to have Spring features into java_client. But careful design should be approached in order to expose ApplicationContext and referenced beans correctly.
TikhomirovSergey commentedon Sep 15, 2015
Ok. I've got and this will be kept in mind.
For now this feature is being just imagined. Also there is some dependency on few PR's to Selenium...
Merge pull request #437 from TikhomirovSergey/#242-fix
appium#242 fix: API was completely designed and implemented
appium#242 fix: some fixes of API implementation. Preparation for the…
appium#242 fix: The general test and bug fixes
appium#242 fix: The test of compatibility with WebDriverEventListener…
appium#242 fix: Everything was finished
appium#242 fix: The new WIKI chapter
appium#242 fix: Working out issues which were found by codecy.
appium#242 fix: The potential bug was fixed.