Setting implicit wait timeout when using PageFactory #203

Activity

1. Jonahss commented on Jun 15, 2015

   

   Jonahss

   on Jun 15, 2015

   Member

   More actions

   @TikhomirovSergey any ideas?
2. TikhomirovSergey commented on Jun 15, 2015

   

   TikhomirovSergey

   on Jun 15, 2015

   Contributor

   More actions

   Hi!
   AppiumFieldDecorator contains time out that has been set. You can try to change it this way:

   afd = new AppiumFieldDecorator(driver, 10, TimeUnit.SECONDS);
   PageFactory.initElements(afd, this);
   //some code 
   afd.resetImplicitlyWaitTimeOut(0, TimeUnit.SECONDS);

   @Simon-Kaz please let me know about the result. If you are still facing the problem please provide a gist with code sample that descrides your use case. ... Still interesting. Why do you need 0-timeout?
3. TikhomirovSergey commented on Jun 18, 2015

   

   TikhomirovSergey

   on Jun 18, 2015

   Contributor

   More actions

   @Simon-Kaz @Jonahss
   I have some ideas...

   It seems some elements need a timeout that differs from the default. What if user would able to define it like that:

   @WithTimeout(timeOut = time, timeUnit = unit)
   @FindBy("your locator")
   WebElement e; //waits for the rendering. Duratin is time out that has been set via @WithTimeout
   
   @FindBy("your another locator")
   WebElement e2; //waits for the rendering. Duratin is time out that has been set by default
   //e.g. PageFactory.initElements(new AppiumFieldDecorator(driver, 10, TimeUnit.SECONDS), this);

   ?
   What do think about this?

   I wish github had a voting for some project features.
4. Simon-Kaz commented on Jun 18, 2015

   

   Simon-Kaz

   on Jun 18, 2015

   Author

   More actions

   Sorry, just getting back to this now. My use case is that I need to set implicit wait to 0 to prevent unnecessary waiting if element is not found.

   I created a custom scrolling method (borrowed a lot from uiAutomator scrolling ;) ) that takes a webElement, as the scrollTo and scrollToExact only take strings, and uiAutomator only takes UiSelector.

   https://gist.github.com/Simon-Kaz/551b66e177c1063893b5

   I check for visibility of element at the beginning, after scrollUpScreenLength , and after every scrollDownScreenLength.

   Now, if the implicit wait is set to, for example, 5 seconds, then every time I check if the element is visible, I will have to wait 5 seconds. I want to reset that timeout so that the isElementVisible takes as little time as possible.
5. TikhomirovSergey commented on Jun 18, 2015

   

   TikhomirovSergey

   on Jun 18, 2015

   Contributor

   More actions

   @Simon-Kaz
   Ок. Does it help (was time out changed?)

   afd = new AppiumFieldDecorator(driver, 10, TimeUnit.SECONDS);
   PageFactory.initElements(afd, this);
   //some code 
   afd.resetImplicitlyWaitTimeOut(0, TimeUnit.SECONDS);

   and what do you think about the idea above?
6. Simon-Kaz commented on Jun 18, 2015

   

   Simon-Kaz

   on Jun 18, 2015

   Author

   More actions

   I haven't tried that yet, I'll try this later today and report my findings ! :)

   I think the additional annotation for timeout could be very useful. For example:

   • an increased timeout could be set for an element that's selected first after opening app - as the process can take much longer on older/slower devices.
   • a reduced timeout could be used for assertions ?
7. Jonahss

   closed this as completedin 246177con Jun 29, 2015
8. Jonahss

   added a commit that references this issue on Jun 29, 2015

   Merge pull request #210 from TikhomirovSergey/#203-fix

   ...

   ddac8ff