ADFA-5062 refactor(setup-progress): read execution class from the mod… - #439
Merged
Merged
Conversation
…el, not the key prefix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…el, not the key prefix
Retires the per-row class derivation in SetupProgressActivity (ADFA-5062, front #3). openDetail no
longer re-derives whether a detail runs with the box stopped from the key prefix; it reads the
execution class from the model — Operation.appInstall(...) for module installs, ContentType.byKey(key)
for content — and gates the "Run in background" button from it (LIVE shows it, STOPPED hides it).
Behaviour-preserving: mod:/maps hide the button (STOPPED), zim/kolibri/books show it (LIVE), as before.
The key→fragment routing stays (presentation); the index-level prootActive() gating is a separate
run-status axis and is untouched. An unknown key now hides the button (conservative; not reachable).