ADFA-4776: Connect — share the library over hotspot / Wi-Fi - #222
Merged
Conversation
… Wi-Fi Replaces the Connect preview shell with a working two-code flow per the final design, reusing the existing backend (no new transport): - Hotspot mode: starts a LocalOnly hotspot (LocalHotspotManager), then a two-step Join -> Open flow. Step 1 shows a QR to join the network (SSID/passphrase fallback below); "show next" advances to step 2, a QR of the browse URL (http://<hotspotIp>:8085) with the URL as fallback. - Wi-Fi mode: no join needed — a single Open QR/URL for devices already on the same LAN (NetworkInterfaces.discover()). - QR bitmaps via QrCodec; ACCESS_FINE_LOCATION requested before starting the hotspot; STARTING / FAILED / unsupported / no-Wi-Fi states handled. - Step badges keep their number and gain a corner check when done (never replace the digit) — matches the wizard's step pattern.
Step 2 only had a backward link ("‹ Back to step 1"), so once the other device was
browsing there was no way forward — the user had to walk back through step 1.
Add a "Done" button above the back link (hotspot, step 2): it ticks step 2 Open
with a corner check, holds ~1.5s so the completion reads, then returns to the
Library tab. Sharing keeps running in the background.
Wi-Fi has no Join→Open steps, so it lacked a forward exit; only the bottom nav returned home. Show the same 'Done' button in the valid Wi-Fi state so both modes end the flow consistently and return to the Library tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the Connect tab functional (was a preview), reusing the existing backend — no new transport.
Related to ADFA-4725.