ADFA-4518 fix(dashboard UX): non-Latin text rendering + nav accessibi… - #116
Merged
Conversation
…lity (first pass) First, most-necessary UX fixes on the current dashboard interface (rest of the polish stays in ADFA-4518): #1 Non-Latin text was broken. The global 'text-transform: uppercase' + 'letter-spacing' on .btn/.nav-text/.sidebar-title detaches Devanagari vowel signs, so Hindi nav/buttons rendered wrong once the locale shipped. Now: - dashboard.js sets <html lang> to the active locale (was always 'en'), so :lang() styling and assistive tech match. - CSS neutralizes text-transform/letter-spacing for :lang(hi) (Latin/Cyrillic keep the existing styling). #2 Nav accessibility. The sidebar items are <a> with onclick and no href, and on mobile only the emoji icon shows (text hidden). Added role=button, tabindex=0 and a localized aria-label (data-i18n-aria-label, reusing nav_* keys) to each nav item + the theme toggle, plus a keydown delegate so Enter/Space activate role=button controls. No TS or locale-key changes, so the dashboard typecheck + lang-parity tests are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lity (first pass)
First, most-necessary UX fixes on the current dashboard interface (rest of the polish stays in ADFA-4518):
#1 Non-Latin text was broken. The global 'text-transform: uppercase' + 'letter-spacing'
on .btn/.nav-text/.sidebar-title detaches Devanagari vowel signs, so Hindi nav/buttons
rendered wrong once the locale shipped. Now:
#2 Nav accessibility. The sidebar items are with onclick and no href, and on mobile
only the emoji icon shows (text hidden). Added role=button, tabindex=0 and a localized
aria-label (data-i18n-aria-label, reusing nav_* keys) to each nav item + the theme
toggle, plus a keydown delegate so Enter/Space activate role=button controls.
No TS or locale-key changes, so the dashboard typecheck + lang-parity tests are unaffected.