[ADFA-365] - project build test with no androidX Project - #8
Merged
Conversation
jatezzz
pushed a commit
that referenced
this pull request
Jun 22, 2026
[ADFA-365] - project build test with no androidX Project
fryanpan
added a commit
that referenced
this pull request
Jul 31, 2026
…ts (map commit #8) Commits 1-7 moved every identifier; this moves the prose that describes them. Zero identifier changes, zero behavior changes - 88 insertions against 88 deletions, every one of them inside a comment, a KDoc/javadoc block, an AIDL javadoc, an XML comment, or a backticked test-method name. Senses renamed - "test app" / "test-app" / "test APK" -> "proxy app" / "proxy app APK", in the quickbuild-runtime AIDL javadoc, its AndroidManifest comments, its runtime javadoc, the daemon's Aapt2Link KDoc, and the runtime module's Gradle description. This is the installed app built from the generated proxy components, never the androidTest instrumentation APK. - "setup build" / "setup-build time" -> "proxy app build" / "proxy app build time", across the same modules plus GradlePluginConfig's javadoc and the gradle-plugin sample project's comment. - "fast path" (retired term) -> "live reload path", in the quick-build classifier/annotations/metrics-sink KDoc, QuickBuildMetrics, QuickBuildJson, and 14 backticked test-method names in ChangeClassifierTest and AnnotationImpactAnalyzerTest. - "rebaseline-on-return hand-back" -> "refresh-baseline-on-return hand-back" in the Quick Build dropdown KDoc: that hand-back after a Standard Run build is RefreshBaseline, not a proxy app rebuild. Two "fast path" occurrences named a different mechanism and were reworded to say what they mean rather than to the new vocabulary: the daemon's Java-ABI skip-recompile shortcut is now "the Java-ABI shortcut" (two test comments), and AndroidProjectWatcher's inotify-vs-poll comment now says "the low-latency path". Deliberately frozen - The fastPathScope() / fastPathRoots identifiers and every KDoc link to them; only the prose around them moved. - ensureBaseline (all 11 sites - it contains the substring "reBaseline"), the testAppId JSON key and its back-compat aliases, the setup.json filename and keys, CodeOnTheGo.qbnoseed. - Bench and Firebase wire strings: "RequiresRebaseline", "Prewarming", "quick_build_rebaseline" and the comments that explain why each is pinned. - Generic English "set up": JUnit setUp() in Aapt2LinkTest and IncrementalCompilerTest, "One-time session setup" on ConfigureRequest, "classpath from setup.json" in DaemonService. - The androidTest sense of "test": TestAppCompatActivity, testAppend. - quick-build/corpus/ and the historical dated docs. - "fail-fast path" in ProxyAppInstaller - a different word that an -i grep for "fast path" still hits. Verification (JUnit XML, not the BUILD SUCCESSFUL line - the root build sets ignoreFailures=true): :quickbuild-runtime:test 552/0, :quickbuild-daemon:test 102/0, :quick-build:test 3510/0, :app:testV8DebugUnitTest 196/0. :gradle-plugin:test 99 tests, 3 failures - the pre-existing AndroidIDEPluginTest logsender trio, unrelated to this change; every quickbuild test passes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QTVTzgiPq4evYCuPLTNUvL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.