ADFA-4128 (7/11): quickbuild:core — provisioning and the daemon client - #1719
Open
fryanpan wants to merge 2 commits into
Open
ADFA-4128 (7/11): quickbuild:core — provisioning and the daemon client#1719fryanpan wants to merge 2 commits into
fryanpan wants to merge 2 commits into
Conversation
fryanpan
force-pushed
the
feature/ADFA-4128-qb-07-core-provisioning
branch
from
August 22, 2026 06:41
6233eb7 to
c6b09f0
Compare
fryanpan
force-pushed
the
feature/ADFA-4128-qb-07-core-provisioning
branch
from
August 22, 2026 07:05
c6b09f0 to
225d08f
Compare
fryanpan
marked this pull request as ready for review
August 23, 2026 02:31
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
fryanpan
force-pushed
the
feature/ADFA-4128-qb-07-core-provisioning
branch
from
August 24, 2026 14:43
225d08f to
ab316b2
Compare
…ll state and the compile-daemon client the pipeline needs first Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kj9YeCDHGp9DU8LPtfWJ7W
…request bound Important 1: unguarded asString on diagnostic severity/message threw out of compile() on object/array values -> primitive-guarded, degrading to ERROR / "unknown error"; covered by `a non-primitive severity or message degrades instead of throwing out of compile`. Important 2: line/column asInt threw NumberFormatException on non-numeric string primitives -> runCatching like the protocol-version read, degrading to absent; covered by `a non-numeric line or column string reads as absent instead of throwing`. Important 3: the request write had no bound, so a wedged child holding a full stdin pipe parked the mutex forever and shutdown() deadlocked on the writer monitor -> write runs on the client scope under requestTimeoutMillis with destroyForcibly on expiry, and shutdown()'s EOF close moved off the teardown path; covered by `a request the daemon never reads times out instead of wedging the client` and `shutdown is not deadlocked by a write the daemon never reads`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kj9YeCDHGp9DU8LPtfWJ7W
fryanpan
force-pushed
the
feature/ADFA-4128-qb-07-core-provisioning
branch
from
August 24, 2026 14:48
ab316b2 to
97f4813
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 7/11 of the stacked split of #1669 (requested by Akash). Base: feature/ADFA-4128-qb-06-core-deploy. Stack overview + review mechanics: PR 1 (#1713). Terms are defined in quickbuild/README.md (lands in PR 1).
Makes sure the two things Quick Build needs before it can start — an installed app to reload into, and a live compiler — are ready, and that it never fights a standard Run for the same install slot.
flowchart LR subgraph s7["<b>This PR: core slice 3 — provisioning + daemon client</b>"] prov["service/provision<br/>proxy-app install state,<br/>stateless install-slot checks<br/><i>QuickBuildClobberCheck.kt</i>"] dc["QuickBuildDaemonController +<br/>DaemonProcessClient (data)<br/>spawn, configure, request matching<br/><i>DaemonProcessClient.kt</i>"] fg["FileGenerationStore (data)<br/>generation counter,<br/>outside the scratch tree<br/><i>FileGenerationStore.kt</i>"] end dc -- "line-delimited JSON<br/>(:quickbuild:protocol, PR 3)" --> d["compile daemon (PR 9)"] sess["session state machine (PR 8)"] -.-> prov sess -.-> dc classDef thisPrBox fill:#dbeafe,stroke:#93c5fd,color:#1e3a5f classDef inPr fill:#ffffff,stroke:#64748b,color:#000 class s7 thisPrBox class prov,dc,fg inPrWhat to review
DaemonProcessClient.kt— the client half: spawn, configure, request/response matching. C11 fix lands here.QuickBuildClobberCheck.kt— confirms the single install slot before either side clobbers.FileGenerationStore.kt— generation counter lives outside the scratch tree; survives teardown.prepare()scratch-tree residue, named rather than silently dropped.How this PR Was Tested
:quickbuild:core:test— runs slices 1-3's tests: 49 suites, 650 tests per variant across all 6 variants, 0 failures, 0 errors. Coverage 98.2% line / 90.1% branch.Coverage (JaCoCo at the stack tip, single run):
…quickbuild.data…quickbuild.service.provision…quickbuild.service.session11 source files in the diff, all 11 measured.
Slice 3 of 4 — next: orchestration (PR 8).
🤖 Generated with Claude Code
https://claude.ai/code/session_01Kj9YeCDHGp9DU8LPtfWJ7W