ADFA-4128 (6/11): quickbuild:core — deploy and reload

[fryanpan]

Part 6/11 of the stacked split of #1669 (requested by Akash). Base: feature/ADFA-4128-qb-05-core-detection. Stack overview + review mechanics: PR 1 (#1713). Terms are defined in quickbuild/README.md (lands in PR 1).

Gets a finished build into the running app by the fastest route that is still correct, and keeps a record of where the time went.

flowchart LR
    route["a classified route<br/>(detection, PR 5)"] --> orch
    subgraph s6["<b>This PR: core slice 2 — deploy and reload</b>"]
        orch["LiveReloadOrchestrator (domain/reload)<br/>one build in flight, supersede,<br/>generations forward-only<br/><i>LiveReloadOrchestrator.kt</i>"] --> pol["DeployPolicy<br/>hot reload vs component restart;<br/>restart rule + logsender exemption<br/><i>DeployPolicy.kt</i>"]
        pol --> ch["DeployChannel + ProxyAppConnections<br/>(service/deploy)<br/>uid-checked binder, payloads as fds<br/><i>DeployChannel.kt</i>"]
        pol --> ln["ProxyAppLauncher<br/>relaunch + retry<br/><i>ProxyAppLauncher.kt</i>"]
        tel["telemetry (domain + service)<br/>stage timings, metrics ports"]
    end
    ch -- "AIDL (runtime's .aidl, PR 4)" --> rt["proxy app runtime"]
    sess["session state machine (PR 8)<br/>drives and observes"] -.-> orch
    classDef thisPrBox fill:#dbeafe,stroke:#93c5fd,color:#1e3a5f
    classDef inPr fill:#ffffff,stroke:#64748b,color:#000
    class s6 thisPrBox
    class orch,pol,ch,ln,tel inPr

Loading

What to review

• DeployPolicy.kt — restart rule; the logsender exemption saves +477 ms per save. Line-by-line.
• LiveReloadOrchestrator.kt — one build in flight; a newer edit supersedes the older.
• DeployChannel.kt — payloads as read-only fds over uid-checked binder; generation-matched reports.
• ProxyAppLauncher.kt — relaunch and retry; rides here because deploy owns relaunch.
• Fakes.kt — test fixture grows across PRs 6-8; no production code moves.
• John's C12 and C3's deploy-policy half folded in as fixes.

How this PR Was Tested

• 21 test files, including SaveCoalescingE2eTest, a JVM end-to-end over fakes.
• [verified 2026-08-21] At this cut: :quickbuild:core:test — runs slices 1-2's tests (the module's compiled-so-far set): 36 suites, 472 tests per variant across all 6 variants, 0 failures, 0 errors. Coverage 95.6% line / 90.3% branch.

Coverage (JaCoCo at the stack tip, single run):

Package	Line	Branch	Note
…quickbuild.data	100.0%	87.5%
…quickbuild.domain.reload	98.7%	92.1%
…quickbuild.domain.session	100.0%	—	no branches
…quickbuild.domain.telemetry	97.1%	98.6%
…quickbuild.service.deploy	92.0%	83.8%	binder-side paths, device-tested
…quickbuild.service.provision	—	—	interface only, no executable lines
…quickbuild.service.telemetry	91.7%	100.0%
NON-UI TOTAL	95.6%	90.3%	1,028 lines, 544 branches

22 source files in the diff, all 22 measured. The service.provision row is ProxyAppLauncher.kt alone, an interface for which JaCoCo emits no counter.

Slice 2 of 4 — next: provisioning (PR 7).

🤖 Generated with Claude Code

https://claude.ai/code/session_01Kj9YeCDHGp9DU8LPtfWJ7W

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

_{Tip: disable this comment in your organization's Code Review settings.}