ADFA-5223: Fix Indonesian "resource" mistranslated as "sumber" (source) - #1711
Conversation
The Indonesian localization rendered the Android term "resource" as "sumber", which means source. The correct term is "sumber daya". Six user-facing strings affected -- five from #1703, plus the pre-existing new_xml_resource. Left "sumber" alone where it correctly means source: idepref_java_diagnosticsEnabled_summary (Java source files), title_open_source_licenses / summary_open_source_licenses (open source), and markdown-preview's view_source. Verified by round-tripping each changed value back to English through both Gemini and Google Cloud Translate; all six now return "resource".
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 Walkthrough
WalkthroughThe changes revise Indonesian translations in three Android resource files. Resource terminology now uses “sumber daya”. String keys, XML structure, and application logic remain unchanged. ChangesIndonesian translation updates
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This is a narrowly scoped Indonesian translation correction with no actionable merge-blocking risk remaining after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Follow-up to #1703. Fixes ADFA-5223.
The Indonesian localization rendered the Android term "resource" as "sumber", which means source. The correct term is "sumber daya" — what Google's own Indonesian Android documentation uses.
Sumberalone is only right for source in the source-code / open-source sense.Six user-facing strings, 6 lines across 3 files. Five came in with #1703;
new_xml_resourceis pre-existing.app/…/values-in/strings.xmlmsg_strings_injection_failedmsg_strings_injection_file_not_foundmsg_strings_injection_invalid_xmlmsg_strings_injection_parser_unsupportedapk-viewer-plugin/…/values-in/strings.xmlsection_resource_directoriesresources/…/values-in-rID/strings.xmlnew_xml_resourceDeliberately not changed
sumberis correct in these — they really do mean source:idepref_java_diagnosticsEnabled_summary— "file sumber Java" (Java source files)title_open_source_licenses/summary_open_source_licenses— "sumber terbuka" (open source)view_source(markdown-preview-plugin) — "Sumber" (view source)Verification
Each changed value was round-tripped back to English through both Gemini and Google Cloud Translate.
Before — both engines independently returned source:
After — both return resource:
All six now back-translate as "resource"; three return the English source verbatim.
Also checked:
%d/%1$splaceholders intact, all three files parse as well-formed XML, and the three legitimatesumberuses above are untouched.No UI layout change — text-only, and the replacement is two words where there was one, so no new truncation risk beyond what the English already has. Not separately re-verified at 2x font scale for that reason.