Repository navigation
Conversation
loadImage took the ImageInputStream out of the Source and never closed it, although PNGFile reads every chunk it keeps into memory in its constructor. The image's file stayed open until garbage collection, with ImageIO's cache file beside it, so on Windows neither could be deleted after rendering. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes XGC-150.
ImageLoaderRawPNG.loadImage()takes theImageInputStreamout of the session'sSource(XmlSourceUtil.removeStreams) and never closes it.PNGFile's constructor already reads every chunk it keeps into memory, andgetImageRawPNG()serves the image data from those byte arrays, so the stream isn't needed oncePNGFileis built.Left open, the PNG's file stays open until garbage collection, together with ImageIO's
imageio*.tmpcache file where the source came from anInputStream. On Windows neither can be deleted after rendering (seen from docx4j, plutext/docx4j#609).The stream is now closed in a
finally, and the stale comment is gone.ImageLoaderRawPNGTestCase.testLoadImageClosesStreamfails without the change; the full test suite passes and checkstyle is clean.