Skip to content

Update dmlc-core, fix default ctors of NodeEntry - #3017

Merged
tqchen merged 6 commits into
apache:masterfrom
larroy:node_ptr
Apr 17, 2019
Merged

tqchen merged 6 commits into
apache:masterfrom
larroy:node_ptr

Conversation

@larroy

@larroy larroy commented Apr 13, 2019

Copy link
Copy Markdown
Contributor

MXNet uses nullptr to designate a node in which autograd is not enabled.

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

@larroy

larroy commented Apr 15, 2019

Copy link
Copy Markdown
Contributor Author

@tqchen is CI working?

@tqchen

tqchen commented Apr 16, 2019

Copy link
Copy Markdown
Member

The CI is reporting lint error that you will need to fix http://ci.tvm.ai:8080/blue/organizations/jenkins/tvm/detail/PR-3017/2/pipeline

@tqchen tqchen added the status: need update need update based on feedbacks label Apr 16, 2019
@tqchen

tqchen commented Apr 16, 2019

Copy link
Copy Markdown
Member

@larroy please act to fix the CI's lint report

@tqchen
tqchen merged commit d5f7224 into apache:master Apr 17, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request May 13, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: need update need update based on feedbacks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants